You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/02 04:11:06 UTC
[GitHub] [rocketmq-streams] xstorm1 opened a new pull request #3: merge to main branch
xstorm1 opened a new pull request #3:
URL: https://github.com/apache/rocketmq-streams/pull/3
merge to main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] xstorm1 commented on pull request #3: merge to main branch
Posted by GitBox <gi...@apache.org>.
xstorm1 commented on pull request #3:
URL: https://github.com/apache/rocketmq-streams/pull/3#issuecomment-890805877
add rocketmq-streams-channel-rocketmq, rocketmq-streams-serviceloader, rocketmq-streams-window modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] xstorm1 commented on a change in pull request #3: merge to main branch
Posted by GitBox <gi...@apache.org>.
xstorm1 commented on a change in pull request #3:
URL: https://github.com/apache/rocketmq-streams/pull/3#discussion_r680785449
##########
File path: rocketmq-streams-channel-rocketmq/rocketmq-streams-channel-rocketmq.iml
##########
@@ -0,0 +1,74 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
I have cleaned up the .class, .jar and .iml files, please confirm it, thks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] odbozhou commented on a change in pull request #3: merge to main branch
Posted by GitBox <gi...@apache.org>.
odbozhou commented on a change in pull request #3:
URL: https://github.com/apache/rocketmq-streams/pull/3#discussion_r680742381
##########
File path: rocketmq-streams-channel-rocketmq/rocketmq-streams-channel-rocketmq.iml
##########
@@ -0,0 +1,74 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
iml files should not be submitted
##########
File path: rocketmq-streams-channel-rocketmq/rocketmq-streams-channel-rocketmq.iml
##########
@@ -0,0 +1,74 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
Please clean up all iml files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] RongtongJin merged pull request #3: merge to main branch
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #3:
URL: https://github.com/apache/rocketmq-streams/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org