You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/09 10:58:14 UTC

[GitHub] [flink] zentol opened a new pull request, #21477: [FLINK-30350][build] Use default location for dependency reduced pom

zentol opened a new pull request, #21477:
URL: https://github.com/apache/flink/pull/21477

   This avoids a side-effect from the shade-plugin where the basedir is set to the target/ directory (the directory that the dependency-reduced-pom is written to).
   
   I will also adjust the .gitignore files for 1.15/1.16 after this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #21477: [FLINK-30350][build] Use default location for dependency reduced pom

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21477:
URL: https://github.com/apache/flink/pull/21477#discussion_r1044418411


##########
flink-dist/pom.xml:
##########
@@ -688,9 +688,7 @@ under the License.
 					</execution>
 					<execution>
 						<!--
-						Disable inherited shade-flink to prevent the Shade plugin from changing the project.basedir. The basedir
-						is changed by the Shade plugin when dependencyReducedPomLocation is set to a different location than the
-						original basedir. We do that in the root pom.xml.
+						Historic artifact; shade-dist execution should be renamed.

Review Comment:
   This is something for a follow-up since it also affects other components (like the license checker)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21477: [FLINK-30350][build] Use default location for dependency reduced pom

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21477:
URL: https://github.com/apache/flink/pull/21477#issuecomment-1344159907

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bfa52fae5b7caf6816eb549a6288b234d17726ca",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bfa52fae5b7caf6816eb549a6288b234d17726ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bfa52fae5b7caf6816eb549a6288b234d17726ca UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #21477: [FLINK-30350][build] Use default location for dependency reduced pom

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21477:
URL: https://github.com/apache/flink/pull/21477#issuecomment-1344365713

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #21477: [FLINK-30350][build] Use default location for dependency reduced pom

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21477:
URL: https://github.com/apache/flink/pull/21477#issuecomment-1383775209

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #21477: [FLINK-30350][build] Use default location for dependency reduced pom

Posted by GitBox <gi...@apache.org>.
zentol merged PR #21477:
URL: https://github.com/apache/flink/pull/21477


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org