[GitHub] [rocketmq] areyouok commented on a change in pull request #1983: fix Broker2Client logs

[GitBox <gi...@apache.org>]

areyouok commented on a change in pull request #1983:
URL: https://github.com/apache/rocketmq/pull/1983#discussion_r425093561



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/client/net/Broker2Client.java
##########
@@ -96,7 +97,7 @@ public void notifyConsumerIdsChanged(
         try {
             this.brokerController.getRemotingServer().invokeOneway(channel, request, 10);
         } catch (Exception e) {
-            log.error("notifyConsumerIdsChanged exception, " + consumerGroup, e.getMessage());
+            log.error("notifyConsumerIdsChanged exception. group={}, error={}", consumerGroup, e.toString());

Review comment:
       Because it may cause too many stacktraces. These error occurs when client is not online.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org