[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2421: [KYUUBI #2028][FOLLOWUP] add engine stop event and fix the partition of initialized event

[GitBox <gi...@apache.org>]

ulysses-you commented on code in PR #2421:
URL: https://github.com/apache/incubator-kyuubi/pull/2421#discussion_r855700297


##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/HiveSQLEngine.scala:
##########
@@ -100,6 +100,9 @@ object HiveSQLEngine extends Logging {
     EventBus.post(event)
     Utils.addShutdownHook(() => {
       engine.getServices.foreach(_.stop())
+      val event = HiveEngineEvent(engine)
+        .copy(state = ServiceState.STOPPED, endTime = System.currentTimeMillis())
+      EventBus.post(event)

Review Comment:
   it's unreliable to do some io work in shutdown hook, can we do this in `stopServer` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org