You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/29 09:02:00 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #975: Ftr/grpc transfer metadata by ctx support
LaurenceLiZhixin opened a new pull request #975:
URL: https://github.com/apache/dubbo-go/pull/975
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Add support of metadata transfer by ctx, when using grpc protocol.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
**Special notes for your reviewer**:
change ctx.Background to ctx, add support in dubbogen tool
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] pantianying commented on pull request #975: Ftr/grpc transfer metadata by ctx support
Posted by GitBox <gi...@apache.org>.
pantianying commented on pull request #975:
URL: https://github.com/apache/dubbo-go/pull/975#issuecomment-752317393
The code is fine for me but I don't know what data you need to fetch in the ctx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #975: Ftr/grpc transfer metadata by ctx support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #975:
URL: https://github.com/apache/dubbo-go/pull/975#issuecomment-752316858
> Is it test successfully?
Yes, this problem is discussed in ding talk group, and developer follow this changes tested successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #975: Ftr/grpc transfer metadata by ctx support
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #975:
URL: https://github.com/apache/dubbo-go/pull/975#issuecomment-752012854
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/975?src=pr&el=h1) Report
> Merging [#975](https://codecov.io/gh/apache/dubbo-go/pull/975?src=pr&el=desc) (35d31fe) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e308e19ad2c0c61738cd496d834bb322b0a0e626?el=desc) (e308e19) will **decrease** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #975 +/- ##
===========================================
- Coverage 59.91% 59.81% -0.11%
===========================================
Files 261 261
Lines 12912 12912
===========================================
- Hits 7736 7723 -13
- Misses 4224 4234 +10
- Partials 952 955 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/grpc/grpc\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/975/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2ludm9rZXIuZ28=) | `73.07% <100.00%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/975/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/975/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/975/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `67.96% <0.00%> (-3.13%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/975/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/975/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/975?src=pr&el=footer). Last update [e308e19...35d31fe](https://codecov.io/gh/apache/dubbo-go/pull/975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #975: Ftr/grpc transfer metadata by ctx support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #975:
URL: https://github.com/apache/dubbo-go/pull/975#issuecomment-752825465
> The code is fine for me but I don't know what data you need to fetch in the ctx
Some developers in dingTalk group said that they want to use metadata to deal with ctx.
like:
`md, ok := metadata.FromIncomingContext(ctx)`
to fetch data in ctx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #975: Ftr/grpc transfer metadata by ctx support
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #975:
URL: https://github.com/apache/dubbo-go/pull/975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org