You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/30 03:21:40 UTC
[GitHub] [iceberg] chenlei677 opened a new pull request #2893: Update the comment content of 'commit.retry.total-timeout-ms'
chenlei677 opened a new pull request #2893:
URL: https://github.com/apache/iceberg/pull/2893
The comment content of the current parameter commit.retry.total-timeout-ms and commit.retry.max-wait-ms is the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] massdosage commented on a change in pull request #2893: Update the comment content of 'commit.retry.total-timeout-ms'
Posted by GitBox <gi...@apache.org>.
massdosage commented on a change in pull request #2893:
URL: https://github.com/apache/iceberg/pull/2893#discussion_r687764150
##########
File path: site/docs/configuration.md
##########
@@ -91,7 +91,7 @@ Iceberg tables support table properties to configure table behavior, like the de
| commit.retry.num-retries | 4 | Number of times to retry a commit before failing |
| commit.retry.min-wait-ms | 100 | Minimum time in milliseconds to wait before retrying a commit |
| commit.retry.max-wait-ms | 60000 (1 min) | Maximum time in milliseconds to wait before retrying a commit |
-| commit.retry.total-timeout-ms | 1800000 (30 min) | Maximum time in milliseconds to wait before retrying a commit |
+| commit.retry.total-timeout-ms | 1800000 (30 min) | Total timeout in milliseconds between retrying a commit. |
Review comment:
```suggestion
| commit.retry.total-timeout-ms | 1800000 (30 min) | Total timeout in milliseconds when retrying a commit. |
```
I think this is a better description of what this does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenlei677 commented on a change in pull request #2893: Update the comment content of 'commit.retry.total-timeout-ms'
Posted by GitBox <gi...@apache.org>.
chenlei677 commented on a change in pull request #2893:
URL: https://github.com/apache/iceberg/pull/2893#discussion_r689990187
##########
File path: site/docs/configuration.md
##########
@@ -91,7 +91,7 @@ Iceberg tables support table properties to configure table behavior, like the de
| commit.retry.num-retries | 4 | Number of times to retry a commit before failing |
| commit.retry.min-wait-ms | 100 | Minimum time in milliseconds to wait before retrying a commit |
| commit.retry.max-wait-ms | 60000 (1 min) | Maximum time in milliseconds to wait before retrying a commit |
-| commit.retry.total-timeout-ms | 1800000 (30 min) | Maximum time in milliseconds to wait before retrying a commit |
+| commit.retry.total-timeout-ms | 1800000 (30 min) | Total timeout in milliseconds between retrying a commit. |
Review comment:
Think about it, it makes sense.I will modify this description. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenlei677 commented on pull request #2893: Update the comment content of 'commit.retry.total-timeout-ms'
Posted by GitBox <gi...@apache.org>.
chenlei677 commented on pull request #2893:
URL: https://github.com/apache/iceberg/pull/2893#issuecomment-894999879
Hi, @massdosage Could you please review this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenlei677 commented on pull request #2893: Update the comment content of 'commit.retry.total-timeout-ms'
Posted by GitBox <gi...@apache.org>.
chenlei677 commented on pull request #2893:
URL: https://github.com/apache/iceberg/pull/2893#issuecomment-890680692
HI, @electrum.
Could you please review this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenlei677 commented on pull request #2893: Update the comment content of 'commit.retry.total-timeout-ms'
Posted by GitBox <gi...@apache.org>.
chenlei677 commented on pull request #2893:
URL: https://github.com/apache/iceberg/pull/2893#issuecomment-901862984
@massdosage Hi, I have updated it here, please help me and check it out again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenlei677 removed a comment on pull request #2893: Update the comment content of 'commit.retry.total-timeout-ms'
Posted by GitBox <gi...@apache.org>.
chenlei677 removed a comment on pull request #2893:
URL: https://github.com/apache/iceberg/pull/2893#issuecomment-890680692
HI, @electrum.
Could you please review this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org