You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by bl...@apache.org on 2022/05/10 02:16:47 UTC
[iceberg] branch master updated: Flink 1.15: Migrate back to use ReusableArrayData (#4712)
This is an automated email from the ASF dual-hosted git repository.
blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/master by this push:
new 21002b229 Flink 1.15: Migrate back to use ReusableArrayData (#4712)
21002b229 is described below
commit 21002b229060cc28115c791e77404aca7bd63d60
Author: Yi Tang <ss...@gmail.com>
AuthorDate: Tue May 10 10:16:43 2022 +0800
Flink 1.15: Migrate back to use ReusableArrayData (#4712)
---
.../java/org/apache/iceberg/flink/data/FlinkParquetReaders.java | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java b/flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java
index 30184d899..b0fb3538e 100644
--- a/flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java
+++ b/flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java
@@ -24,12 +24,10 @@ import java.math.BigInteger;
import java.nio.ByteBuffer;
import java.time.Instant;
import java.time.ZoneOffset;
-import java.util.Arrays;
import java.util.List;
import java.util.Map;
import org.apache.flink.table.data.ArrayData;
import org.apache.flink.table.data.DecimalData;
-import org.apache.flink.table.data.GenericArrayData;
import org.apache.flink.table.data.GenericRowData;
import org.apache.flink.table.data.MapData;
import org.apache.flink.table.data.RawValueData;
@@ -484,10 +482,8 @@ public class FlinkParquetReaders {
@Override
protected ArrayData buildList(ReusableArrayData list) {
- // Since ReusableArrayData is not accepted by Flink, use GenericArrayData temporarily to walk around it.
- // Revert this to use ReusableArrayData once it is fixed in Flink.
- // For your reference, https://issues.apache.org/jira/browse/FLINK-25238.
- return new GenericArrayData(Arrays.copyOf(list.values, writePos));
+ list.setNumElements(writePos);
+ return list;
}
}