You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Rakesh Gupta <ra...@gmail.com> on 2023/12/01 13:20:31 UTC

Re: Review Request 74753: RANGER-4521: All records not displayed on Admin Audits UI when filtered using session ID

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74753/
-----------------------------------------------------------

(Updated Dec. 1, 2023, 1:20 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

password change audit entries were missing


Bugs: RANGER-4521
    https://issues.apache.org/jira/browse/RANGER-4521


Repository: ranger


Description
-------

Some audit entries for keyadmin user are missing when filtered using sessionID or Audit Type = Ranger Policy. Also when moved to next page most audit entries are missing

(Audits for import and export are shown, audit corresponding to policy crud operation is missing for keyadmin user)


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 9d9e0bbc0 


Diff: https://reviews.apache.org/r/74753/diff/2/

Changes: https://reviews.apache.org/r/74753/diff/1-2/


Testing
-------

Tested All audits are displayed properly with filter and without filter for admin and keyadmin user.


Thanks,

Rakesh Gupta


Re: Review Request 74753: RANGER-4521: All records not displayed on Admin Audits UI when filtered using session ID

Posted by Rakesh Gupta <ra...@gmail.com>.

> On Dec. 19, 2023, 6:30 a.m., Kishor Gollapalliwar wrote:
> > security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java
> > Lines 154 (patched)
> > <https://reviews.apache.org/r/74753/diff/4/?file=2284289#file2284289line215>
> >
> >     What will happen if session is null ?

if session is null, we will get all transaction log


- Rakesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74753/#review226062
-----------------------------------------------------------


On Dec. 19, 2023, 9:57 a.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74753/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2023, 9:57 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4521
>     https://issues.apache.org/jira/browse/RANGER-4521
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some audit entries for keyadmin user are missing when filtered using sessionID or Audit Type = Ranger Policy. Also when moved to next page most audit entries are missing
> 
> (Audits for import and export are shown, audit corresponding to policy crud operation is missing for keyadmin user)
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 9d9e0bbc0 
> 
> 
> Diff: https://reviews.apache.org/r/74753/diff/5/
> 
> 
> Testing
> -------
> 
> Tested All audits are displayed properly with filter and without filter for admin and keyadmin user.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 74753: RANGER-4521: All records not displayed on Admin Audits UI when filtered using session ID

Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74753/#review226062
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java
Line 111 (original), 106 (patched)
<https://reviews.apache.org/r/74753/#comment314379>

    Please handle scenario when session is null



security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java
Lines 154 (patched)
<https://reviews.apache.org/r/74753/#comment314380>

    What will happen if session is null ?


- Kishor Gollapalliwar


On Dec. 14, 2023, 7:26 a.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74753/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2023, 7:26 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4521
>     https://issues.apache.org/jira/browse/RANGER-4521
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some audit entries for keyadmin user are missing when filtered using sessionID or Audit Type = Ranger Policy. Also when moved to next page most audit entries are missing
> 
> (Audits for import and export are shown, audit corresponding to policy crud operation is missing for keyadmin user)
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 9d9e0bbc0 
> 
> 
> Diff: https://reviews.apache.org/r/74753/diff/4/
> 
> 
> Testing
> -------
> 
> Tested All audits are displayed properly with filter and without filter for admin and keyadmin user.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 74753: RANGER-4521: All records not displayed on Admin Audits UI when filtered using session ID

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74753/#review226111
-----------------------------------------------------------


Ship it!




Ship It!

- Dineshkumar Yadav


On Dec. 19, 2023, 9:57 a.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74753/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2023, 9:57 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4521
>     https://issues.apache.org/jira/browse/RANGER-4521
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some audit entries for keyadmin user are missing when filtered using sessionID or Audit Type = Ranger Policy. Also when moved to next page most audit entries are missing
> 
> (Audits for import and export are shown, audit corresponding to policy crud operation is missing for keyadmin user)
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 9d9e0bbc0 
> 
> 
> Diff: https://reviews.apache.org/r/74753/diff/5/
> 
> 
> Testing
> -------
> 
> Tested All audits are displayed properly with filter and without filter for admin and keyadmin user.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 74753: RANGER-4521: All records not displayed on Admin Audits UI when filtered using session ID

Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74753/#review226089
-----------------------------------------------------------


Ship it!




Ship It!

- Kishor Gollapalliwar


On Dec. 19, 2023, 9:57 a.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74753/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2023, 9:57 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4521
>     https://issues.apache.org/jira/browse/RANGER-4521
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some audit entries for keyadmin user are missing when filtered using sessionID or Audit Type = Ranger Policy. Also when moved to next page most audit entries are missing
> 
> (Audits for import and export are shown, audit corresponding to policy crud operation is missing for keyadmin user)
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 9d9e0bbc0 
> 
> 
> Diff: https://reviews.apache.org/r/74753/diff/5/
> 
> 
> Testing
> -------
> 
> Tested All audits are displayed properly with filter and without filter for admin and keyadmin user.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 74753: RANGER-4521: All records not displayed on Admin Audits UI when filtered using session ID

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74753/
-----------------------------------------------------------

(Updated Dec. 19, 2023, 9:57 a.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Review comment handles


Bugs: RANGER-4521
    https://issues.apache.org/jira/browse/RANGER-4521


Repository: ranger


Description
-------

Some audit entries for keyadmin user are missing when filtered using sessionID or Audit Type = Ranger Policy. Also when moved to next page most audit entries are missing

(Audits for import and export are shown, audit corresponding to policy crud operation is missing for keyadmin user)


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 9d9e0bbc0 


Diff: https://reviews.apache.org/r/74753/diff/5/

Changes: https://reviews.apache.org/r/74753/diff/4-5/


Testing
-------

Tested All audits are displayed properly with filter and without filter for admin and keyadmin user.


Thanks,

Rakesh Gupta


Re: Review Request 74753: RANGER-4521: All records not displayed on Admin Audits UI when filtered using session ID

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74753/
-----------------------------------------------------------

(Updated Dec. 14, 2023, 7:26 a.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4521
    https://issues.apache.org/jira/browse/RANGER-4521


Repository: ranger


Description
-------

Some audit entries for keyadmin user are missing when filtered using sessionID or Audit Type = Ranger Policy. Also when moved to next page most audit entries are missing

(Audits for import and export are shown, audit corresponding to policy crud operation is missing for keyadmin user)


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 9d9e0bbc0 


Diff: https://reviews.apache.org/r/74753/diff/4/

Changes: https://reviews.apache.org/r/74753/diff/3-4/


Testing
-------

Tested All audits are displayed properly with filter and without filter for admin and keyadmin user.


Thanks,

Rakesh Gupta


Re: Review Request 74753: RANGER-4521: All records not displayed on Admin Audits UI when filtered using session ID

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74753/
-----------------------------------------------------------

(Updated Dec. 13, 2023, 12:57 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Fetching keyadmin audit entries by query.


Bugs: RANGER-4521
    https://issues.apache.org/jira/browse/RANGER-4521


Repository: ranger


Description
-------

Some audit entries for keyadmin user are missing when filtered using sessionID or Audit Type = Ranger Policy. Also when moved to next page most audit entries are missing

(Audits for import and export are shown, audit corresponding to policy crud operation is missing for keyadmin user)


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 9d9e0bbc0 


Diff: https://reviews.apache.org/r/74753/diff/3/

Changes: https://reviews.apache.org/r/74753/diff/2-3/


Testing
-------

Tested All audits are displayed properly with filter and without filter for admin and keyadmin user.


Thanks,

Rakesh Gupta