You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2012/04/10 19:02:11 UTC

svn commit: r1311869 - /lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java

Author: rmuir
Date: Tue Apr 10 17:02:11 2012
New Revision: 1311869

URL: http://svn.apache.org/viewvc?rev=1311869&view=rev
Log:
LUCENE-3969: promote edgeNgrams from 'totally broken list' to 'broken offsets list'

Modified:
    lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java

Modified: lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java?rev=1311869&r1=1311868&r2=1311869&view=diff
==============================================================================
--- lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java (original)
+++ lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java Tue Apr 10 17:02:11 2012
@@ -113,11 +113,7 @@ public class TestRandomChains extends Ba
                                  LimitTokenCountFilter.class,
                                  // Not broken: we forcefully add this, so we shouldn't
                                  // also randomly pick it:
-                                 ValidatingTokenFilter.class,
-                                 // nocommit: randomly generate the Side enum param here; then promote to brokenOffsets?
-                                 EdgeNGramTokenizer.class,
-                                 // nocommit: randomly generate the Side enum param here; then promote to brokenOffsets?
-                                 EdgeNGramTokenFilter.class
+                                 ValidatingTokenFilter.class
     );
   }
 
@@ -138,6 +134,10 @@ public class TestRandomChains extends Ba
                                  NGramTokenizer.class,
                                  // broken!
                                  NGramTokenFilter.class,
+                                 // broken!
+                                 EdgeNGramTokenizer.class,
+                                 // broken!
+                                 EdgeNGramTokenFilter.class,
                                  // nocommit it seems to mess up offsets!?
                                  WikipediaTokenizer.class
                                  );
@@ -356,6 +356,20 @@ public class TestRandomChains extends Ba
         }
       }
     });
+    put(EdgeNGramTokenizer.Side.class, new ArgProducer() {
+      @Override public Object create(Random random) {
+        return random.nextBoolean() 
+            ? EdgeNGramTokenizer.Side.FRONT 
+            : EdgeNGramTokenizer.Side.BACK;
+      }
+    });
+    put(EdgeNGramTokenFilter.Side.class, new ArgProducer() {
+      @Override public Object create(Random random) {
+        return random.nextBoolean() 
+            ? EdgeNGramTokenFilter.Side.FRONT 
+            : EdgeNGramTokenFilter.Side.BACK;
+      }
+    });
     put(HyphenationTree.class, new ArgProducer() {
       @Override public Object create(Random random) {
         // TODO: make nastier