You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/13 06:58:14 UTC
[GitHub] [cloudstack] borisstoyanov opened a new issue #4400: Find suitable storage for migration regression
borisstoyanov opened a new issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
VMware migration, API
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master branch.
-->
~~~
4.14
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
VMware
##### SUMMARY
<!-- Explain the problem/feature briefly -->
When executing the api agains attached volume we observe that none of the pools is marked suitable, a little investigation was done suspecting the following change:
https://github.com/shapeblue/cloudstack/blob/ovfprops-and-vsphere-adv-together/server/src/main/java/com/cloud/server/ManagementServerImpl.java#L156
```
//This is an override mechanism so we can list the possible local storage pools that a volume in a shared pool might be able to be migrated to
diskProfile.setUseLocalStorage(true);
```
Before searching for the suitable storage pools, volume is marked as using local storage just to also find any local storage pools to which volume can be migrated along with the shared storage pools.
But this is causing regression for zone wide storage pools, while zone wide storage pool allocator searches for any zone wide storage pools the entrance check is
`if (dskCh.useLocalStorage()) { return null;}
`which causing zone wide storage pool allocator returning nothing and at the end findStoragePoolsForMigration API shows all zone wide storage pools are “not suitable“.
Below is the screenshot of a volume which is not associated with any storage policy but still showing “vvol5-zone“ as “not suitable“.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-773996890
marking 4.16 as #4304 is as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-731023181
@harikrishna-patnala the intention is to list all the storage pools and mark as suitable / unsuitable. If unsuitable pool is selected for migration, the appropriate cmd is sent to hypervisor resource for migration. If succeeds, the offering, etc. applicable details are updated, else keeps the same.
Please take a look at the actual implementation in the PRs: https://github.com/apache/cloudstack/pull/2425 and https://github.com/apache/cloudstack/pull/2486.
The override mechanism in these changes is skipping the zone wide pools, which are also has to be considered. In order to consider these, that cond. have to be removed. Otherwise, there is no way to migrate to zone wide pool using _findStoragePoolsForMigration_ API from UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-707540591
@borisstoyanov the check in the Zone wide pool allocator `if (dskCh.useLocalStorage()) { return null;}` should be ok, as the local storage can never be a zone wide pool and the disk profile want to find suitable local storage pools only, as the flag useLocalStorage is set. "useLocalStorage" should be appropriately set to find the local pools only, for zone / cluster-wide pool, this flag should be set to false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-770905995
@borisstoyanov can you check in 4.15?
also the link in the summary gives me a 404, can you update the description, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-731012003
@sureshanaparti if we remove the local storage condition from ZoneWideStoragePoolAllocator then it implies that any volume on local or cluster scoped or zone wide storage can be migrated to zone wide storage. If those operations are functionally allowed then the fix that you mentioned is fine.
Can you please confirm if volumes on any storage(local, cluster, zone) can be migrated to zone wide storage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rafaelweingartner commented on issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
rafaelweingartner commented on issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-754882634
@harikrishna-patnala and @sureshanaparti exactly that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-707540591
@borisstoyanov the check in the Zone wide pool allocator `if (dskCh.useLocalStorage()) { return null;}` should be ok, as the local storage can never be a zone wide pool and the disk profile want to find suitable local storage pools only, as the flag useLocalStorage is set. "useLocalStorage" is appropriately set to find the local pools, for zone / cluster-wide pool, this is set to false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-731023181
@harikrishna-patnala the intention is to list all the storage pools and mark as suitable / unsuitable. If unsuitable pool is selected for migration, the appropriate cmd is sent to hypervisor resource for migration. If succeeds, the offering, etc. applicable details are updated, else keeps the same.
Please take a look at the actual implementation in the PRs: https://github.com/apache/cloudstack/pull/2425 and https://github.com/apache/cloudstack/pull/2486.
The override mechanism in these changes is skipping the zone wide pools, which are also has to be considered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on issue #4400: Find suitable storage for migration regression
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #4400:
URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-730996383
The override mechanism to list the possible local storage pools is skipping the zone wide pools, and so when migrating a volume attached to a running VM doesn't list zone wide pool as a suitable pool in UI, with _findStoragePoolsForMigration_ API.
To fix this and consider zone wide pools for migration, the condition` if (dskCh.useLocalStorage()) { return null;}` has to be removed from ZoneWideStoragePoolAllocator. This is already addressed in PR https://github.com/apache/cloudstack/pull/4304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org