You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jaikiran Pai <ja...@gmail.com> on 2015/01/07 05:26:06 UTC
Review request for patch attached to KAFKA-1836
Hello Kafka team,
I was just looking around some newbie bugs in the JIRA, during the
weekend, and decided to take up
https://issues.apache.org/jira/browse/KAFKA-1836. I've a patch, which
I've attached to that JIRA a few days back, which I would like to be
reviewed. The patch handles the case where the awaitUpdate timeout value
for Metadata updates is lesser than or equal to 0. It also has the
documentation and config for metadata.fetch.timeout.ms property updated.
Finally it has a testcase which verifies this change.
Could one of you please take a look?
-Jaikiran
Re: Review request for patch attached to KAFKA-1836
Posted by Joe Stein <jo...@stealth.ly>.
Sounds good, if you need access to Confluence send along your Confluence
username and I will grant you access if you need to update the document.
/*******************************************
Joe Stein
Founder, Principal Consultant
Big Data Open Source Security LLC
http://www.stealth.ly
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
********************************************/
On Wed, Jan 7, 2015 at 12:11 AM, Jaikiran Pai <ja...@gmail.com>
wrote:
> Thanks Joe, I'll do that. I had indeed quickly looked at that document
> over the weekend but I saw that it was missing instructions for Debian
> based systems (am on LinuxMint) and so decided to skip that for now till I
> understand the whole tool chain. I'll see which of these tools I need to
> install and how to set them up (and if needed add those instructions to
> that document)
>
> -Jaikiran
> On Wednesday 07 January 2015 10:04 AM, Joe Stein wrote:
>
>> Hi Jaikiran, do you mind utilizing the kafka patch review tool please
>> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool
>> as it is helpful for folks to comment on your code lines as it posts to
>> review board for you and updates JIRA too.
>>
>> /*******************************************
>> Joe Stein
>> Founder, Principal Consultant
>> Big Data Open Source Security LLC
>> http://www.stealth.ly
>> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
>> ********************************************/
>>
>> On Tue, Jan 6, 2015 at 11:26 PM, Jaikiran Pai <ja...@gmail.com>
>> wrote:
>>
>> Hello Kafka team,
>>>
>>> I was just looking around some newbie bugs in the JIRA, during the
>>> weekend, and decided to take up https://issues.apache.org/
>>> jira/browse/KAFKA-1836. I've a patch, which I've attached to that JIRA a
>>> few days back, which I would like to be reviewed. The patch handles the
>>> case where the awaitUpdate timeout value for Metadata updates is lesser
>>> than or equal to 0. It also has the documentation and config for
>>> metadata.fetch.timeout.ms property updated. Finally it has a testcase
>>> which verifies this change.
>>>
>>> Could one of you please take a look?
>>>
>>>
>>> -Jaikiran
>>>
>>>
>
Re: Review request for patch attached to KAFKA-1836
Posted by Jaikiran Pai <ja...@gmail.com>.
I've now updated the patch submission page to include instructions for
installation on Debian based systems and also added an overview section
to help understand what the Kafka patch submission tool is for
https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review
-Jaikiran
On Wednesday 07 January 2015 10:41 AM, Jaikiran Pai wrote:
> Thanks Joe, I'll do that. I had indeed quickly looked at that document
> over the weekend but I saw that it was missing instructions for Debian
> based systems (am on LinuxMint) and so decided to skip that for now
> till I understand the whole tool chain. I'll see which of these tools
> I need to install and how to set them up (and if needed add those
> instructions to that document)
>
> -Jaikiran
> On Wednesday 07 January 2015 10:04 AM, Joe Stein wrote:
>> Hi Jaikiran, do you mind utilizing the kafka patch review tool please
>> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool
>>
>> as it is helpful for folks to comment on your code lines as it posts to
>> review board for you and updates JIRA too.
>>
>> /*******************************************
>> Joe Stein
>> Founder, Principal Consultant
>> Big Data Open Source Security LLC
>> http://www.stealth.ly
>> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
>> ********************************************/
>>
>> On Tue, Jan 6, 2015 at 11:26 PM, Jaikiran Pai <ja...@gmail.com>
>> wrote:
>>
>>> Hello Kafka team,
>>>
>>> I was just looking around some newbie bugs in the JIRA, during the
>>> weekend, and decided to take up https://issues.apache.org/
>>> jira/browse/KAFKA-1836. I've a patch, which I've attached to that
>>> JIRA a
>>> few days back, which I would like to be reviewed. The patch handles the
>>> case where the awaitUpdate timeout value for Metadata updates is lesser
>>> than or equal to 0. It also has the documentation and config for
>>> metadata.fetch.timeout.ms property updated. Finally it has a testcase
>>> which verifies this change.
>>>
>>> Could one of you please take a look?
>>>
>>>
>>> -Jaikiran
>>>
>
Re: Review request for patch attached to KAFKA-1836
Posted by Jaikiran Pai <ja...@gmail.com>.
Thanks Joe, I'll do that. I had indeed quickly looked at that document
over the weekend but I saw that it was missing instructions for Debian
based systems (am on LinuxMint) and so decided to skip that for now till
I understand the whole tool chain. I'll see which of these tools I need
to install and how to set them up (and if needed add those instructions
to that document)
-Jaikiran
On Wednesday 07 January 2015 10:04 AM, Joe Stein wrote:
> Hi Jaikiran, do you mind utilizing the kafka patch review tool please
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool
> as it is helpful for folks to comment on your code lines as it posts to
> review board for you and updates JIRA too.
>
> /*******************************************
> Joe Stein
> Founder, Principal Consultant
> Big Data Open Source Security LLC
> http://www.stealth.ly
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> ********************************************/
>
> On Tue, Jan 6, 2015 at 11:26 PM, Jaikiran Pai <ja...@gmail.com>
> wrote:
>
>> Hello Kafka team,
>>
>> I was just looking around some newbie bugs in the JIRA, during the
>> weekend, and decided to take up https://issues.apache.org/
>> jira/browse/KAFKA-1836. I've a patch, which I've attached to that JIRA a
>> few days back, which I would like to be reviewed. The patch handles the
>> case where the awaitUpdate timeout value for Metadata updates is lesser
>> than or equal to 0. It also has the documentation and config for
>> metadata.fetch.timeout.ms property updated. Finally it has a testcase
>> which verifies this change.
>>
>> Could one of you please take a look?
>>
>>
>> -Jaikiran
>>
Re: Review request for patch attached to KAFKA-1836
Posted by Joe Stein <jo...@stealth.ly>.
Hi Jaikiran, do you mind utilizing the kafka patch review tool please
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool
as it is helpful for folks to comment on your code lines as it posts to
review board for you and updates JIRA too.
/*******************************************
Joe Stein
Founder, Principal Consultant
Big Data Open Source Security LLC
http://www.stealth.ly
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
********************************************/
On Tue, Jan 6, 2015 at 11:26 PM, Jaikiran Pai <ja...@gmail.com>
wrote:
> Hello Kafka team,
>
> I was just looking around some newbie bugs in the JIRA, during the
> weekend, and decided to take up https://issues.apache.org/
> jira/browse/KAFKA-1836. I've a patch, which I've attached to that JIRA a
> few days back, which I would like to be reviewed. The patch handles the
> case where the awaitUpdate timeout value for Metadata updates is lesser
> than or equal to 0. It also has the documentation and config for
> metadata.fetch.timeout.ms property updated. Finally it has a testcase
> which verifies this change.
>
> Could one of you please take a look?
>
>
> -Jaikiran
>