[servicecomb-java-chassis] branch master updated: [SCB-2464] Fix spotbugs SIC_INNER_SHOULD_BE_STATIC (#2800)

[li...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new 1f666a69f [SCB-2464] Fix spotbugs SIC_INNER_SHOULD_BE_STATIC (#2800)
1f666a69f is described below

commit 1f666a69f1ade45145ceb4fab16d29817528f0c1
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Mon Apr 25 20:20:05 2022 +0800

    [SCB-2464] Fix spotbugs SIC_INNER_SHOULD_BE_STATIC (#2800)
---
 ci/spotbugs/exclude.xml                                               | 4 ----
 .../apache/servicecomb/registry/version/VersionRuleLatestParser.java  | 2 +-
 .../servicecomb/loadbalance/filter/IsolationDiscoveryFilter.java      | 2 +-
 .../apache/servicecomb/authentication/provider/AccessController.java  | 2 +-
 .../provider/springmvc/reference/CseClientHttpRequest.java            | 3 ---
 5 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/ci/spotbugs/exclude.xml b/ci/spotbugs/exclude.xml
index eee7b5e25..e0b6e6c48 100644
--- a/ci/spotbugs/exclude.xml
+++ b/ci/spotbugs/exclude.xml
@@ -171,10 +171,6 @@
         <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
     </Match>
 
-    <Match>
-        <Bug pattern="SIC_INNER_SHOULD_BE_STATIC"/>
-    </Match>
-
     <Match>
         <Bug pattern="SSD_DO_NOT_USE_INSTANCE_LOCK_ON_SHARED_STATIC_DATA"/>
     </Match>
diff --git a/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/version/VersionRuleLatestParser.java b/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/version/VersionRuleLatestParser.java
index 2714611fd..053318453 100644
--- a/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/version/VersionRuleLatestParser.java
+++ b/foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/version/VersionRuleLatestParser.java
@@ -21,7 +21,7 @@ import org.apache.servicecomb.foundation.common.Version;
 import org.apache.servicecomb.registry.definition.DefinitionConst;
 
 public class VersionRuleLatestParser implements VersionRuleParser {
-  class LatestVersionRule extends VersionRule {
+  static class LatestVersionRule extends VersionRule {
     public LatestVersionRule(String versionRule) {
       super(versionRule);
     }
diff --git a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filter/IsolationDiscoveryFilter.java b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filter/IsolationDiscoveryFilter.java
index 5f38bd51e..744c6fdb9 100644
--- a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filter/IsolationDiscoveryFilter.java
+++ b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filter/IsolationDiscoveryFilter.java
@@ -53,7 +53,7 @@ public class IsolationDiscoveryFilter implements DiscoveryFilter {
   private final DynamicBooleanProperty emptyProtection = DynamicPropertyFactory.getInstance()
       .getBooleanProperty(EMPTY_INSTANCE_PROTECTION, false);
 
-  public class Settings {
+  public static class Settings {
     public int errorThresholdPercentage;
 
     public long singleTestTime;
diff --git a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/AccessController.java b/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/AccessController.java
index e5a991de9..cafd71718 100644
--- a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/AccessController.java
+++ b/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/AccessController.java
@@ -35,7 +35,7 @@ import com.netflix.config.DynamicPropertyFactory;
  * Add black / white list control to service access
  */
 public class AccessController {
-  class ConfigurationItem {
+  static class ConfigurationItem {
     static final String CATEGORY_PROPERTY = "property";
 
     String category;
diff --git a/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/CseClientHttpRequest.java b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/CseClientHttpRequest.java
index 3761cdb9d..db5a52f9e 100644
--- a/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/CseClientHttpRequest.java
+++ b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/CseClientHttpRequest.java
@@ -42,8 +42,6 @@ import org.apache.servicecomb.core.provider.consumer.ReferenceConfig;
 import org.apache.servicecomb.swagger.invocation.Response;
 import org.apache.servicecomb.swagger.invocation.context.InvocationContext;
 import org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpMethod;
 import org.springframework.http.client.ClientHttpRequest;
@@ -54,7 +52,6 @@ import com.fasterxml.jackson.databind.type.TypeFactory;
 import io.netty.handler.codec.http.QueryStringDecoder;
 
 public class CseClientHttpRequest implements ClientHttpRequest {
-  private static final Logger LOGGER = LoggerFactory.getLogger(CseClientHttpRequest.class);
 
   // URL format：cse://microserviceName/business url
   private URI uri;