Re: [PR] beam-sql.sh, a standalone launcher for Beam SQL Shell [beam]

["talatuyarer (via GitHub)" <gi...@apache.org>]

talatuyarer commented on code in PR #36305:
URL: https://github.com/apache/beam/pull/36305#discussion_r2398392069


##########
website/www/site/content/en/documentation/dsls/sql/shell.md:
##########
@@ -112,23 +166,28 @@ When you're satisfied with the logic of your SQL statements, you can submit the
 
 ## Specifying the Runner
 
-By default, Beam uses the `DirectRunner` to run the pipeline on the machine where you're executing the commands. If you want to run the pipeline with a different runner, you must perform two steps:
+By default, Beam uses the `DirectRunner` to run the pipeline on the machine where you're executing the commands. If you want to run the pipeline with a different runner, you can specify it using the `beam-sql.sh` script:
+
+### Using beam-sql.sh Script
 
-1.  Make sure the SQL shell includes the desired runner. Add the corresponding project id to the `-Pbeam.sql.shell.bundled` parameter of the Gradle invocation ([source code](https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/shell/build.gradle), [project ids](https://github.com/apache/beam/blob/master/settings.gradle.kts)). For example, use the following command to include Flink runner and KafkaIO:
+When using the `beam-sql.sh` script, you can specify the runner directly via command-line options:
 
-    ```
-    ./gradlew -p sdks/java/extensions/sql/jdbc -Pbeam.sql.shell.bundled=':runners:flink:1.17,:sdks:java:io:kafka' installDist
-    ```
+```bash
+# Use Dataflow runner
+./beam-sql.sh --runner dataflow
 
-    _Note: You can bundle multiple runners (using a comma-separated list) or other additional components in the same manner. For example, you can add support for more I/Os._
+# Use Dataflow runner with specific IO connectors

Review Comment:
   No need this. It is runner v1. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org