[GitHub] [beam] pskevin commented on a change in pull request #12635: [BEAM-9919] Isolating xlang transforms by namespace

[GitBox <gi...@apache.org>]

pskevin commented on a change in pull request #12635:
URL: https://github.com/apache/beam/pull/12635#discussion_r473436448



##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/namespace.go
##########
@@ -0,0 +1,136 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for Additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package xlangx
+
+import (
+	"fmt"
+
+	"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
+	pipepb "github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1"
+)
+
+func AddCoderID(c *pipepb.Components, idMap map[string]string, cid string, newID func(string) string) string {
+	if _, exists := idMap[cid]; exists {
+		return idMap[cid]
+	}
+
+	coder, exists := c.Coders[cid]
+	if !exists {
+		panic(errors.Errorf("attempted to add namespace to missing coder id: %v not in %v", cid, c.Coders))
+	}
+
+	// Updating ComponentCoderIDs of Coder
+	if coder.GetComponentCoderIds() != nil {
+		updatedComponentCoderIDs := coder.ComponentCoderIds // Pass by value

Review comment:
       Ack. Updated!

##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/namespace.go
##########
@@ -0,0 +1,136 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for Additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package xlangx
+
+import (
+	"fmt"
+
+	"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
+	pipepb "github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1"
+)
+
+func AddCoderID(c *pipepb.Components, idMap map[string]string, cid string, newID func(string) string) string {
+	if _, exists := idMap[cid]; exists {
+		return idMap[cid]
+	}
+
+	coder, exists := c.Coders[cid]
+	if !exists {
+		panic(errors.Errorf("attempted to add namespace to missing coder id: %v not in %v", cid, c.Coders))
+	}
+
+	// Updating ComponentCoderIDs of Coder
+	if coder.GetComponentCoderIds() != nil {
+		updatedComponentCoderIDs := coder.ComponentCoderIds // Pass by value
+		for i, ccid := range coder.ComponentCoderIds {
+			updatedComponentCoderIDs[i] = AddCoderID(c, idMap, ccid, newID)
+			coder.ComponentCoderIds = updatedComponentCoderIDs

Review comment:
       Ack. Updated!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org