You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/16 07:21:32 UTC

[GitHub] [tvm] masahi opened a new pull request, #13631: [Arith] Allow const folding on fp16 involving one and zero

masahi opened a new pull request, #13631:
URL: https://github.com/apache/tvm/pull/13631

   Since https://github.com/apache/tvm/pull/12515, const folding on fp16, when both lhs and rhs are constant, is disabled. This is the case even when one of the arguments are one or zero. This leads to a real problem described in https://github.com/apache/tvm/pull/13532#issuecomment-1353715208. So in practice, compiling winograd fp16 on GPU is currently broken. 
   
   This PR enables trivial algebraic simplification for fp16 const folding when (1) both arguments are constant and (2) one or both of the inputs are one or zero. Since we already does such simplification when only one of the inputs are constant (for example https://github.com/apache/tvm/blob/3a639a41a830ece914df10a98f807123e46cd750/src/arith/const_fold.h#L209-L216), I just removed all early exit `return NullOpt;` for fp16 cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 merged pull request #13631: [Arith] Allow const folding on fp16 involving one and zero

Posted by GitBox <gi...@apache.org>.

vinx13 merged PR #13631:
URL: https://github.com/apache/tvm/pull/13631


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13631: [Arith] Allow const folding on fp16 involving one and zero

Posted by GitBox <gi...@apache.org>.

tvm-bot commented on PR #13631:
URL: https://github.com/apache/tvm/pull/13631#issuecomment-1354321344

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @junrushao <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org