You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/04/08 07:53:27 UTC

[GitHub] beiwei30 commented on issue #1511: Add feature���require Reference service dynamically

beiwei30 commented on issue #1511: Add feature:require Reference service dynamically
URL: https://github.com/apache/incubator-dubbo/pull/1511#issuecomment-379529154
 
 
   I am afraid I cannot accept this change because the following reasons:
   
   1. From dubbo's user doc, the group is designed to distinguish the different impls as you planned to give the support here, see http://dubbo.apache.org/books/dubbo-user-book/demos/service-group.html. That is, you could always look up the desired ReferenceBean with the given id, that means `DynamicReferenceService` is unnecessary
   
   ```java
   <dubbo:reference id="feedbackIndexService" group="feedback" interface="com.xxx.IndexService" />
   <dubbo:reference id="memberIndexService" group="member" interface="com.xxx.IndexService" />
   ``` 
   
   2. I am not convinced that RefConf should be introduced, since it looks very familiar with com.alibaba.dubbo.config.ReferenceConfig#ReferenceConfig(com.alibaba.dubbo.config.annotation.Reference)
   3. com.alibaba.dubbo.config.spring.AnnotationBean is deprecated, we should not add more functionality on this class
   4. some minor issues including:
       * missing license header
       * comments in Chinese
       * author info should be removed
   
   Feel free to reopen and let's discuss further if appropriated.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services