[jira] [Commented] (BEAM-1411) Unable to downgrade to lower guava version after upgrade to beam-0.5

["Daniel Halperin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856291#comment-15856291 ] 

Daniel Halperin commented on BEAM-1411:
---------------------------------------

Hi [~michel],

Thanks for the report, and good sleuthing!

Early on we were very good about shading, but newer modules maybe not as much. We need to get this cleaned up before the next release.

Would you mind sending a PR to implement the shading? Can model it after https://github.com/apache/beam/pull/1906

We could presumably also use a new unit test to catch these types of issues in the future.

Thanks,
Dan

> Unable to downgrade to lower guava version after upgrade to beam-0.5
> --------------------------------------------------------------------
>
>                 Key: BEAM-1411
>                 URL: https://issues.apache.org/jira/browse/BEAM-1411
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 0.5.0
>            Reporter: Michael Luckey
>            Assignee: Davor Bonaci
>
> While testing upgrading to 0.5 version of beam we ran into NoSuchMethodErrors
> {noformat}
> java.lang.NoSuchMethodError: com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V
>  at org.apache.beam.sdk.io.hdfs.HDFSFileSource$SerializableSplit.<init>(HDFSFileSource.java:473)
>  at org.apache.beam.sdk.io.hdfs.AvroHDFSFileSource$1.apply(AvroHDFSFileSource.java:81)
>  at org.apache.beam.sdk.io.hdfs.AvroHDFSFileSource$1.apply(AvroHDFSFileSource.java:78)
>  at com.google.common.collect.Lists$TransformingRandomAccessList.get(Lists.java:451)
>  at java.util.AbstractList$Itr.next(AbstractList.java:358)
>  at org.apache.beam.runners.direct.BoundedReadEvaluatorFactory$InputProvider.getInitialInputs(BoundedReadEvaluatorFactory.java:202)
>  at org.apache.beam.runners.direct.RootProviderRegistry.getInitialInputs(RootProviderRegistry.java:65)
>  at org.apache.beam.runners.direct.ExecutorServiceParallelExecutor.start(ExecutorServiceParallelExecutor.java:168)
>  at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:329)
>  at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:71)
>  at org.apache.beam.sdk.Pipeline.run(Pipeline.java:178)
>  at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:258)
> {noformat}
> This seems to be caused by the [HDFS IO|https://github.com/apache/beam/tree/master/sdks/java/io/hdfs] components guava dependency not being shaded - in contrast to the core components - and revealed by the [recent update to guava-20.0|https://github.com/apache/beam/commit/0b4b2becb45b9f637ba31f599ebe8be0331bd633] and the therefore incorporated api changes made by [overloading methods|https://github.com/google/guava/commit/892e323fca32945cdfb25395ca6e346dd0fffa5b#diff-fe7358934fa6eba23c2791eb40cec030]
> Did not check, whether more components are affected to.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)