You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/08/05 19:34:36 UTC
Review Request 37133: Add a frameworks parameter to the hierarchical
allocator benchmark.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37133/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-3209
https://issues.apache.org/jira/browse/MESOS-3209
Repository: mesos
Description
-------
Parameterize the hierarchical allocator benchmark by the framework
count as well as the slave count. This can be used to explore
allocation behavior as the number of frameworks increases.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp c92d47aa0a06088f1f8fe749a629c27bfadd3c6d
Diff: https://reviews.apache.org/r/37133/diff/
Testing
-------
make check
make bench
Thanks,
James Peach
Re: Review Request 37133: Add a frameworks parameter to the
hierarchical allocator benchmark.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37133/#review95027
-----------------------------------------------------------
Ship it!
Sorry this took so long, I'll get this committed for you now.
src/tests/hierarchical_allocator_tests.cpp (line 1119)
<https://reviews.apache.org/r/37133/#comment149806>
This comment seems a bit misleading, since each slave only has allocation for 1 framework. I'll re-phrase it.
- Ben Mahler
On Aug. 5, 2015, 5:34 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37133/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 5:34 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3209
> https://issues.apache.org/jira/browse/MESOS-3209
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Parameterize the hierarchical allocator benchmark by the framework
> count as well as the slave count. This can be used to explore
> allocation behavior as the number of frameworks increases.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp c92d47aa0a06088f1f8fe749a629c27bfadd3c6d
>
> Diff: https://reviews.apache.org/r/37133/diff/
>
>
> Testing
> -------
>
> make check
> make bench
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 37133: Add a frameworks parameter to the
hierarchical allocator benchmark.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37133/#review94297
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37133]
All tests passed.
- Mesos ReviewBot
On Aug. 5, 2015, 5:34 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37133/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 5:34 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3209
> https://issues.apache.org/jira/browse/MESOS-3209
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Parameterize the hierarchical allocator benchmark by the framework
> count as well as the slave count. This can be used to explore
> allocation behavior as the number of frameworks increases.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp c92d47aa0a06088f1f8fe749a629c27bfadd3c6d
>
> Diff: https://reviews.apache.org/r/37133/diff/
>
>
> Testing
> -------
>
> make check
> make bench
>
>
> Thanks,
>
> James Peach
>
>