You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Chris Hostetter <ho...@fucit.org> on 2007/09/06 17:44:50 UTC

Re: svn commit: r573296 - /lucene/solr/trunk/client/ruby/solr-ruby/CHANGES.yml

: Log:
: Fix YAML parsing issue

Erik: Are you reading perl blogs now or did someone email you about this?

(you seem to have single handedly started a movement)
http://use.perl.org/articles/07/09/06/0324215.shtml


-Hoss


Re: svn commit: r573296 - /lucene/solr/trunk/client/ruby/solr-ruby/CHANGES.yml

Posted by Erik Hatcher <er...@ehatchersolutions.com>.
On Sep 6, 2007, at 10:25 PM, Chris Hostetter wrote:
> : Kinda cute, but not worth starting a revolution about.  Structure is
> : overrated.
>
> you mean you aren't going to make the build fail if the CHANGES.yml  
> file
> can't be parsed?  :)

Now there's an idea!  Committed a unit test for this.  Need to wire  
it into the "rake package" task to run unit tests, and voila, done.

	Erik


Re: svn commit: r573296 - /lucene/solr/trunk/client/ruby/solr-ruby/CHANGES.yml

Posted by Chris Hostetter <ho...@fucit.org>.
: Kinda cute, but not worth starting a revolution about.  Structure is
: overrated.

you mean you aren't going to make the build fail if the CHANGES.yml file 
can't be parsed?  :)



-Hoss


Re: svn commit: r573296 - /lucene/solr/trunk/client/ruby/solr-ruby/CHANGES.yml

Posted by Erik Hatcher <er...@ehatchersolutions.com>.
On Sep 6, 2007, at 11:44 AM, Chris Hostetter wrote:

>
> : Log:
> : Fix YAML parsing issue
>
> Erik: Are you reading perl blogs now or did someone email you about  
> this?
>
> (you seem to have single handedly started a movement)
> http://use.perl.org/articles/07/09/06/0324215.shtml

I got alerted through my aggregator somehow of this:

   http://bricas.vox.com/library/post/changesyml-spec.html

and the same guy posted it over to the link you sent which he shared  
with me in #code4lib earlier today.  So no, not reading Perl blogs, I  
got much sharper sticks I'd rather stick in my eye!  But I did  
stumble on that one today and indeed I had gotten lax and screwed up  
the data structure it parsed to.  Now its a clean Ruby Hash like this:

$ jirb
irb(main):001:0> require 'yaml'
=> true
irb(main):002:0>  YAML.load_file('/Users/erik/dev/solr/client/ruby/ 
solr-ruby/CHANGES.yml')
=> {"v0.0.2"=>{"changes"=>["mappers, etc"], "release_date"=>#<Date:  
4908471/2,0,2299161>}, "v0.0.3"=>{"changes"=>["Adjusted HpricotMapper  
and XPathMapper, and tests, to load only if their dependencies are  
available."], "release_date"=>#<Date: 4908485/2,0,2299161>},  
"v0.0.4"=>{"changes"=>["Solr::Indexer#solr added to gain access to  
the Solr::Connection instance", "Fixed issue with multi-line String  
field values when field set multiValued=\"false\"", "Fixed tests to  
work without either Hpricot or libxml2"], "release_date"=>#<Date:  
4908657/2,0,2299161>}, "v0.0.5"=>{"changes"=>["Added support for  
highlighter fragment size to Solr::Request::Standard", "Added support  
for MoreLikeThese to Solr::Request::Standard", "Added  
Solr::Request::ModifyDocument (requires SOLR-139 patch)", "Added  
Solr::Util.query_parser_escape()"], "release_date"=>"2007-08-??"},  
"v0.0.1"=>{"changes"=>["initial release"], "release_date"=>#<Date:  
4908293/2,0,2299161>}}

Kinda cute, but not worth starting a revolution about.  Structure is  
overrated.

	Erik