You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Gordon Mohr (JIRA)" <ji...@apache.org> on 2006/05/19 03:32:06 UTC
[jira] Created: (HTTPCORE-4) feature request: optional header
limits to contain OOME risks
feature request: optional header limits to contain OOME risks
-------------------------------------------------------------
Key: HTTPCORE-4
URL: http://issues.apache.org/jira/browse/HTTPCORE-4
Project: Jakarta HttpCore
Type: New Feature
Components: HttpCore
Versions: 4.0-alpha1
Reporter: Gordon Mohr
It would be desirable to be able to specify limits in the parsing of HTTP messages, so that impractically large content (inadvertently or maliciously) fails in a manageable way, rather than triggering an OutOfMemoryError.
One possibility would be to set limits on HTTP header line lengths and number of headers; once exceeded, an exception would be thrown.
Another would be to set a byte-total cap on how much content can be considered to contribute to the headers; past that cap, an exception would be thrown.
A possible wrinkle would be implementing compatible limits at other places mid- or late-message where unbounded numbers of headers could again appear (multipart; chunked; footers).
See also:
http://issues.apache.org/jira/browse/HTTPCORE-3?page=all
http://issues.apache.org/bugzilla/show_bug.cgi?id=25468
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-4) feature request: optional header
limits to contain OOME risks
Posted by "Ortwin Glück (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCORE-4?page=comments#action_12414383 ]
Ortwin Glück commented on HTTPCORE-4:
-------------------------------------
Looks good! I think that solved it. The API Doc should probably mention the meaning of -1 for those limits.
> feature request: optional header limits to contain OOME risks
> -------------------------------------------------------------
>
> Key: HTTPCORE-4
> URL: http://issues.apache.org/jira/browse/HTTPCORE-4
> Project: Jakarta HttpCore
> Type: New Feature
> Components: HttpCore
> Versions: 4.0-alpha1
> Reporter: Gordon Mohr
> Assignee: Oleg Kalnichevski
> Fix For: 4.0-alpha2
>
> It would be desirable to be able to specify limits in the parsing of HTTP messages, so that impractically large content (inadvertently or maliciously) fails in a manageable way, rather than triggering an OutOfMemoryError.
> One possibility would be to set limits on HTTP header line lengths and number of headers; once exceeded, an exception would be thrown.
> Another would be to set a byte-total cap on how much content can be considered to contribute to the headers; past that cap, an exception would be thrown.
> A possible wrinkle would be implementing compatible limits at other places mid- or late-message where unbounded numbers of headers could again appear (multipart; chunked; footers).
> See also:
> http://issues.apache.org/jira/browse/HTTPCORE-3?page=all
> http://issues.apache.org/bugzilla/show_bug.cgi?id=25468
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-4) feature request: optional header
limits to contain OOME risks
Posted by "Ortwin Glück (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCORE-4?page=comments#action_12414262 ]
Ortwin Glück commented on HTTPCORE-4:
-------------------------------------
The line length limitting looks okay. I am still missing a limit for the number of headers. A malicious server could send an infinite amount of headers and exhaust memory.
> feature request: optional header limits to contain OOME risks
> -------------------------------------------------------------
>
> Key: HTTPCORE-4
> URL: http://issues.apache.org/jira/browse/HTTPCORE-4
> Project: Jakarta HttpCore
> Type: New Feature
> Components: HttpCore
> Versions: 4.0-alpha1
> Reporter: Gordon Mohr
> Assignee: Oleg Kalnichevski
> Fix For: 4.0-alpha2
>
> It would be desirable to be able to specify limits in the parsing of HTTP messages, so that impractically large content (inadvertently or maliciously) fails in a manageable way, rather than triggering an OutOfMemoryError.
> One possibility would be to set limits on HTTP header line lengths and number of headers; once exceeded, an exception would be thrown.
> Another would be to set a byte-total cap on how much content can be considered to contribute to the headers; past that cap, an exception would be thrown.
> A possible wrinkle would be implementing compatible limits at other places mid- or late-message where unbounded numbers of headers could again appear (multipart; chunked; footers).
> See also:
> http://issues.apache.org/jira/browse/HTTPCORE-3?page=all
> http://issues.apache.org/bugzilla/show_bug.cgi?id=25468
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Updated: (HTTPCORE-4) feature request: optional header
limits to contain OOME risks
Posted by "Ortwin Glück (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCORE-4?page=all ]
Ortwin Glück updated HTTPCORE-4:
--------------------------------
Fix Version: 4.0-alpha2
> feature request: optional header limits to contain OOME risks
> -------------------------------------------------------------
>
> Key: HTTPCORE-4
> URL: http://issues.apache.org/jira/browse/HTTPCORE-4
> Project: Jakarta HttpCore
> Type: New Feature
> Components: HttpCore
> Versions: 4.0-alpha1
> Reporter: Gordon Mohr
> Fix For: 4.0-alpha2
>
> It would be desirable to be able to specify limits in the parsing of HTTP messages, so that impractically large content (inadvertently or maliciously) fails in a manageable way, rather than triggering an OutOfMemoryError.
> One possibility would be to set limits on HTTP header line lengths and number of headers; once exceeded, an exception would be thrown.
> Another would be to set a byte-total cap on how much content can be considered to contribute to the headers; past that cap, an exception would be thrown.
> A possible wrinkle would be implementing compatible limits at other places mid- or late-message where unbounded numbers of headers could again appear (multipart; chunked; footers).
> See also:
> http://issues.apache.org/jira/browse/HTTPCORE-3?page=all
> http://issues.apache.org/bugzilla/show_bug.cgi?id=25468
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-4) feature request: optional header
limits to contain OOME risks
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCORE-4?page=comments#action_12414255 ]
Oleg Kalnichevski commented on HTTPCORE-4:
------------------------------------------
Folks,
I have checked in a fix for the problem, see the SVN revision link below
http://svn.apache.org/viewvc?view=rev&revision=410884
Please review and let me know if something is not okay
Oleg
> feature request: optional header limits to contain OOME risks
> -------------------------------------------------------------
>
> Key: HTTPCORE-4
> URL: http://issues.apache.org/jira/browse/HTTPCORE-4
> Project: Jakarta HttpCore
> Type: New Feature
> Components: HttpCore
> Versions: 4.0-alpha1
> Reporter: Gordon Mohr
> Assignee: Oleg Kalnichevski
> Fix For: 4.0-alpha2
>
> It would be desirable to be able to specify limits in the parsing of HTTP messages, so that impractically large content (inadvertently or maliciously) fails in a manageable way, rather than triggering an OutOfMemoryError.
> One possibility would be to set limits on HTTP header line lengths and number of headers; once exceeded, an exception would be thrown.
> Another would be to set a byte-total cap on how much content can be considered to contribute to the headers; past that cap, an exception would be thrown.
> A possible wrinkle would be implementing compatible limits at other places mid- or late-message where unbounded numbers of headers could again appear (multipart; chunked; footers).
> See also:
> http://issues.apache.org/jira/browse/HTTPCORE-3?page=all
> http://issues.apache.org/bugzilla/show_bug.cgi?id=25468
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-4) feature request: optional header
limits to contain OOME risks
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCORE-4?page=comments#action_12414381 ]
Oleg Kalnichevski commented on HTTPCORE-4:
------------------------------------------
Added max header count check
http://svn.apache.org/viewvc?rev=411100&view=rev
Please review
Oleg
> feature request: optional header limits to contain OOME risks
> -------------------------------------------------------------
>
> Key: HTTPCORE-4
> URL: http://issues.apache.org/jira/browse/HTTPCORE-4
> Project: Jakarta HttpCore
> Type: New Feature
> Components: HttpCore
> Versions: 4.0-alpha1
> Reporter: Gordon Mohr
> Assignee: Oleg Kalnichevski
> Fix For: 4.0-alpha2
>
> It would be desirable to be able to specify limits in the parsing of HTTP messages, so that impractically large content (inadvertently or maliciously) fails in a manageable way, rather than triggering an OutOfMemoryError.
> One possibility would be to set limits on HTTP header line lengths and number of headers; once exceeded, an exception would be thrown.
> Another would be to set a byte-total cap on how much content can be considered to contribute to the headers; past that cap, an exception would be thrown.
> A possible wrinkle would be implementing compatible limits at other places mid- or late-message where unbounded numbers of headers could again appear (multipart; chunked; footers).
> See also:
> http://issues.apache.org/jira/browse/HTTPCORE-3?page=all
> http://issues.apache.org/bugzilla/show_bug.cgi?id=25468
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-4) feature request: optional header
limits to contain OOME risks
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCORE-4?page=comments#action_12414388 ]
Oleg Kalnichevski commented on HTTPCORE-4:
------------------------------------------
Thanks, Odi. I added some more javadocs and will close the bug shortly if I hear no complaints
Oleg
> feature request: optional header limits to contain OOME risks
> -------------------------------------------------------------
>
> Key: HTTPCORE-4
> URL: http://issues.apache.org/jira/browse/HTTPCORE-4
> Project: Jakarta HttpCore
> Type: New Feature
> Components: HttpCore
> Versions: 4.0-alpha1
> Reporter: Gordon Mohr
> Assignee: Oleg Kalnichevski
> Fix For: 4.0-alpha2
>
> It would be desirable to be able to specify limits in the parsing of HTTP messages, so that impractically large content (inadvertently or maliciously) fails in a manageable way, rather than triggering an OutOfMemoryError.
> One possibility would be to set limits on HTTP header line lengths and number of headers; once exceeded, an exception would be thrown.
> Another would be to set a byte-total cap on how much content can be considered to contribute to the headers; past that cap, an exception would be thrown.
> A possible wrinkle would be implementing compatible limits at other places mid- or late-message where unbounded numbers of headers could again appear (multipart; chunked; footers).
> See also:
> http://issues.apache.org/jira/browse/HTTPCORE-3?page=all
> http://issues.apache.org/bugzilla/show_bug.cgi?id=25468
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Resolved: (HTTPCORE-4) feature request: optional header
limits to contain OOME risks
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCORE-4?page=all ]
Oleg Kalnichevski resolved HTTPCORE-4:
--------------------------------------
Resolution: Fixed
> feature request: optional header limits to contain OOME risks
> -------------------------------------------------------------
>
> Key: HTTPCORE-4
> URL: http://issues.apache.org/jira/browse/HTTPCORE-4
> Project: Jakarta HttpCore
> Type: New Feature
> Components: HttpCore
> Versions: 4.0-alpha1
> Reporter: Gordon Mohr
> Assignee: Oleg Kalnichevski
> Fix For: 4.0-alpha2
>
> It would be desirable to be able to specify limits in the parsing of HTTP messages, so that impractically large content (inadvertently or maliciously) fails in a manageable way, rather than triggering an OutOfMemoryError.
> One possibility would be to set limits on HTTP header line lengths and number of headers; once exceeded, an exception would be thrown.
> Another would be to set a byte-total cap on how much content can be considered to contribute to the headers; past that cap, an exception would be thrown.
> A possible wrinkle would be implementing compatible limits at other places mid- or late-message where unbounded numbers of headers could again appear (multipart; chunked; footers).
> See also:
> http://issues.apache.org/jira/browse/HTTPCORE-3?page=all
> http://issues.apache.org/bugzilla/show_bug.cgi?id=25468
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
[jira] Assigned: (HTTPCORE-4) feature request: optional header
limits to contain OOME risks
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HTTPCORE-4?page=all ]
Oleg Kalnichevski reassigned HTTPCORE-4:
----------------------------------------
Assign To: Oleg Kalnichevski
> feature request: optional header limits to contain OOME risks
> -------------------------------------------------------------
>
> Key: HTTPCORE-4
> URL: http://issues.apache.org/jira/browse/HTTPCORE-4
> Project: Jakarta HttpCore
> Type: New Feature
> Components: HttpCore
> Versions: 4.0-alpha1
> Reporter: Gordon Mohr
> Assignee: Oleg Kalnichevski
> Fix For: 4.0-alpha2
>
> It would be desirable to be able to specify limits in the parsing of HTTP messages, so that impractically large content (inadvertently or maliciously) fails in a manageable way, rather than triggering an OutOfMemoryError.
> One possibility would be to set limits on HTTP header line lengths and number of headers; once exceeded, an exception would be thrown.
> Another would be to set a byte-total cap on how much content can be considered to contribute to the headers; past that cap, an exception would be thrown.
> A possible wrinkle would be implementing compatible limits at other places mid- or late-message where unbounded numbers of headers could again appear (multipart; chunked; footers).
> See also:
> http://issues.apache.org/jira/browse/HTTPCORE-3?page=all
> http://issues.apache.org/bugzilla/show_bug.cgi?id=25468
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org