You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/08/30 22:45:18 UTC
[jira] [Created] (HBASE-4304) requestsPerSecond counter stuck at 0
requestsPerSecond counter stuck at 0
------------------------------------
Key: HBASE-4304
URL: https://issues.apache.org/jira/browse/HBASE-4304
Project: HBase
Issue Type: Bug
Components: master, regionserver
Affects Versions: 0.92.0
Reporter: Todd Lipcon
Priority: Critical
Fix For: 0.92.0
Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "Li Pi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4304:
-------------------------
Status: Open (was: Patch Available)
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136726#comment-13136726 ]
Li Pi commented on HBASE-4304:
------------------------------
Do these patches need to svn patches?
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136851#comment-13136851 ]
Li Pi commented on HBASE-4304:
------------------------------
done. going to sleep now.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136841#comment-13136841 ]
stack commented on HBASE-4304:
------------------------------
@Li Yeah. Svn for now. Do what Mr. Todd says.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "Li Pi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4304:
-------------------------
Attachment: 4304v1.txt
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "subramanian raghunathan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100252#comment-13100252 ]
subramanian raghunathan commented on HBASE-4304:
------------------------------------------------
I want to provide my analysis & background since its relatd to HBASE-3807 fixed
by me earlier
1) Previously the problem was present only in the region server.
As part of defect
HBASE-3807:Fix units in RS UI metrics
I had changed the HServerLoad also to use the region server metrics and made it to be consistent as {color:green}requestPerSecond {color}.
{code}
return new HServerLoad(requestCount.get(),(int)metrics.getRequests(),
(int)(memory.getUsed() / 1024 / 1024),
(int) (memory.getMax() / 1024 / 1024), regionLoads);
{code}
Request per second value derived from here :{color:green}(int)metrics.getRequests(){color}
2) But what i missed to find out was the region server metrics itself was not functioning properly.
Digged in and found following things.
1) HRegionServer.run() method is the major source of value provided for request.It runs by default every three seconds
{code}
if ((now - lastMsg) >= msgInterval) {
{code}
The request count is populated here into the metrics as part of the doMetrics method.
{code}
this.metrics.incrementRequests(this.requestCount.get())
{code}
will go and update the metrics rate thro the method
{code}
public synchronized void inc(final int incr) {
value += incr;
}
{code}
{color:green}This gives the request received between the previous run and current run.{color}
But the request per second value will be populated only when the following piece gets executed of the class MetricsRate
{code}
private synchronized void intervalHeartBeat() {
long now = System.currentTimeMillis();
long diff = (now-ts)/1000;
if (diff == 0) diff = 1; // sigh this is crap.
this.prevRate = (float)value / diff;
this.value = 0;
this.ts = now;
}
@Override
public synchronized void pushMetric(final MetricsRecord mr) {
intervalHeartBeat();
try {
mr.setMetric(getName(), getPreviousIntervalValue());
} catch (Exception e) {
LOG.info("pushMetric failed for " + getName() + "\n" +
StringUtils.stringifyException(e));
}
}
{code}
{color:red} pushMetric wont be invoked by default since the metrics won't be enabled by default
hbase.class=org.apache.hadoop.metrics.spi.NullContext.
Please do correct me if i am wrong here{color}
So ideally the value is always displayed as zero.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136842#comment-13136842 ]
stack commented on HBASE-4304:
------------------------------
@Li Click the 'Cancel Patch' at the head of his JIRA, upload your --no-prefix git thingy, then submit the patch again.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137791#comment-13137791 ]
Li Pi commented on HBASE-4304:
------------------------------
Isn't diff in seconds? If so, I meant if diff < 1.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "subramanian raghunathan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100263#comment-13100263 ]
subramanian raghunathan commented on HBASE-4304:
------------------------------------------------
@LiPi are you working on this patch?
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "Li Pi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4304:
-------------------------
Attachment: 4304v3.txt
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107569#comment-13107569 ]
Li Pi commented on HBASE-4304:
------------------------------
Working on this now. I see it being updated at :this.metrics.readRequestsCount.set(readRequestsCount);
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134801#comment-13134801 ]
stack commented on HBASE-4304:
------------------------------
@Li Any update on this one boss?
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136715#comment-13136715 ]
Hadoop QA commented on HBASE-4304:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501015/4304v1.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/76//console
This message is automatically generated.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136920#comment-13136920 ]
Hadoop QA commented on HBASE-4304:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501046/4304v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -167 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.metrics.TestMetricsMBeanBase
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/77//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/77//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/77//console
This message is automatically generated.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138744#comment-13138744 ]
Hudson commented on HBASE-4304:
-------------------------------
Integrated in HBase-TRUNK #2379 (See [https://builds.apache.org/job/HBase-TRUNK/2379/])
HBASE-4304 requestsPerSecond counter stuck at 0
stack :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/MetricsRate.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt, 4304v4.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140839#comment-13140839 ]
Hudson commented on HBASE-4304:
-------------------------------
Integrated in HBase-0.92 #90 (See [https://builds.apache.org/job/HBase-0.92/90/])
HBASE-4304 requestsPerSecond counter stuck at 0
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/MetricsRate.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt, 4304v4.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135534#comment-13135534 ]
Li Pi commented on HBASE-4304:
------------------------------
On it!
On Tue, Oct 25, 2011 at 12:16 AM, stack (Commented) (JIRA)
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138024#comment-13138024 ]
stack commented on HBASE-4304:
------------------------------
Or you want to make a new patch?
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137152#comment-13137152 ]
Ted Yu commented on HBASE-4304:
-------------------------------
@Li:
Please address TestMetricsMBeanBase first.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi reassigned HBASE-4304:
----------------------------
Assignee: Li Pi
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "Li Pi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4304:
-------------------------
Status: Patch Available (was: Open)
fixed.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "Li Pi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4304:
-------------------------
Status: Patch Available (was: Open)
Fixed tests.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "Li Pi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4304:
-------------------------
Attachment: 4304v2.txt
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "Li Pi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4304:
-------------------------
Status: Open (was: Patch Available)
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100552#comment-13100552 ]
Li Pi commented on HBASE-4304:
------------------------------
Yup. Its on my barnburner. But I do intend to complete it.
On Sep 8, 2011 5:26 AM, "subramanian raghunathan (JIRA)" <ji...@apache.org>
https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100263#comment-13100263]
showing 0 both in the master UI and in the RS UI. The writeRequestsCount
metric is properly updating in the RS UI.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4304:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Applied branch and trunk. Thanks for the patch Li.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt, 4304v4.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "subramanian raghunathan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100261#comment-13100261 ]
subramanian raghunathan commented on HBASE-4304:
------------------------------------------------
What i felt as corrective action could be is like :
{code}
protected void metrics() {
this.metrics.regions.set(this.onlineRegions.size());
this.metrics.incrementRequests(this.requestCount.get());
//TODO:compute the request per second here
{code}
{color:green}//TODO:compute the request per second here {color}
So the the request per second value will be fixed till the next run
which will be recalculated in the next run and the counter is reset to zero as part of
{code}
void tryRegionServerReport()
throws IOException {
HServerLoad hsl = buildServerLoad();
// Why we do this?
this.requestCount.set(0);
{code}
{color:red}But this has a contradiction with the usage of context based metrics update , when the context is enabled.
There could be a chance of race in the computation of the value.
The race will be resetting of the value to zero {this.value = 0;}
after computation {color}
{code}
private synchronized void intervalHeartBeat() {
long now = System.currentTimeMillis();
long diff = (now-ts)/1000;
if (diff == 0) diff = 1; // sigh this is crap.
this.prevRate = (float)value / diff;
this.value = 0;
this.ts = now;
}
{code}
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138022#comment-13138022 ]
stack commented on HBASE-4304:
------------------------------
@Li Want me to make it that way on commit? (You'd have the same logic as previous effectively).
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "Li Pi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4304:
-------------------------
Status: Patch Available (was: Open)
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137461#comment-13137461 ]
stack commented on HBASE-4304:
------------------------------
{code}
long now = System.currentTimeMillis();
long diff = (now-ts)/1000;
- if (diff == 0) diff = 1; // sigh this is crap.
+ if (diff < 0.5){
{code}
diff is a long. It can't be 0.5. You want to use a float or something?
Should the below instead be an accessor on RSM rather than expose the data member?
{code}
- private final MetricsRate requests = new MetricsRate("requests", registry);
+ public final MetricsRate requests = new MetricsRate("requests", registry);
{code}
Good stuff Li. Agree on failing tests.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137445#comment-13137445 ]
Hadoop QA commented on HBASE-4304:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501125/4304v3.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -167 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.master.TestMasterFailover
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/80//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/80//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/80//console
This message is automatically generated.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138026#comment-13138026 ]
Li Pi commented on HBASE-4304:
------------------------------
Yeah sure
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4304) requestsPerSecond counter stuck at 0
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4304:
-------------------------
Attachment: 4304v4.txt
Here is what I applied. I tested it too. Seems to work.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt, 4304v4.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138029#comment-13138029 ]
Li Pi commented on HBASE-4304:
------------------------------
Sure to just modifying it and committing. I'm on cell phone.
On Thu, Oct 27, 2011 at 10:00 PM, Li Pi (Commented) (JIRA)
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136740#comment-13136740 ]
Todd Lipcon commented on HBASE-4304:
------------------------------------
Try "git show --no-prefix" or "git diff --no-prefix" instead. That way it will apply with patch -p0 and should work in test-patch (if it's like Hadoop's old test-patch script)
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4304) requestsPerSecond counter stuck at
0
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137447#comment-13137447 ]
Li Pi commented on HBASE-4304:
------------------------------
My testing shows
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.master.TestMasterFailover
fails anyways.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0 both in the master UI and in the RS UI. The writeRequestsCount metric is properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira