You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2010/01/08 07:53:04 UTC
[jira] Created: (HBASE-2097) Deadlock between HRegion.put and
HRegion.close
Deadlock between HRegion.put and HRegion.close
----------------------------------------------
Key: HBASE-2097
URL: https://issues.apache.org/jira/browse/HBASE-2097
Project: Hadoop HBase
Issue Type: Bug
Reporter: Jean-Daniel Cryans
Priority: Blocker
Fix For: 0.20.3
HBASE-2037 added a bunch of fixes but also a deadlock:
HRegion.put:
{code}
splitsAndClosesLock.readLock().lock();
newScannerLock.writeLock().lock();
{code}
HRegion.close
{code}
newScannerLock.writeLock().lock();
try {
splitsAndClosesLock.writeLock().lock();
{code}
To recreate, start a PerformanceEvaluation on standalone and it happens roughly 75% of the time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2097) Deadlock between HRegion.put and
HRegion.close
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-2097.
---------------------------------------
Resolution: Fixed
Assignee: stack
Hadoop Flags: [Reviewed]
I also tried the patch a couple of times and the deadlock is gone. I'm committing the patch to branch plus I removed some annoying debug (MemStoreScanner) that was also added in HBASE-2037.
> Deadlock between HRegion.put and HRegion.close
> ----------------------------------------------
>
> Key: HBASE-2097
> URL: https://issues.apache.org/jira/browse/HBASE-2097
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: stack
> Priority: Blocker
> Fix For: 0.20.3
>
> Attachments: 2097.patch
>
>
> HBASE-2037 added a bunch of fixes but also a deadlock:
> HRegion.put:
> {code}
> splitsAndClosesLock.readLock().lock();
> newScannerLock.writeLock().lock();
> {code}
> HRegion.close
> {code}
> newScannerLock.writeLock().lock();
> try {
> splitsAndClosesLock.writeLock().lock();
> {code}
> To recreate, start a PerformanceEvaluation on standalone and it happens roughly 75% of the time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2097) Deadlock between HRegion.put and
HRegion.close
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2097:
-------------------------
Attachment: 2097.patch
Locks being done in wrong order. This patch should fix it. Testing.
> Deadlock between HRegion.put and HRegion.close
> ----------------------------------------------
>
> Key: HBASE-2097
> URL: https://issues.apache.org/jira/browse/HBASE-2097
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.20.3
>
> Attachments: 2097.patch
>
>
> HBASE-2037 added a bunch of fixes but also a deadlock:
> HRegion.put:
> {code}
> splitsAndClosesLock.readLock().lock();
> newScannerLock.writeLock().lock();
> {code}
> HRegion.close
> {code}
> newScannerLock.writeLock().lock();
> try {
> splitsAndClosesLock.writeLock().lock();
> {code}
> To recreate, start a PerformanceEvaluation on standalone and it happens roughly 75% of the time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2097) Deadlock between HRegion.put and
HRegion.close
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798253#action_12798253 ]
stack commented on HBASE-2097:
------------------------------
To reproduce -- from J-D -- run in standalone mode (I couldn't repro on cluster). After reproducing on first run, after application of this patch, hang hasn't happened after trying sequentialWrite 4 times.
> Deadlock between HRegion.put and HRegion.close
> ----------------------------------------------
>
> Key: HBASE-2097
> URL: https://issues.apache.org/jira/browse/HBASE-2097
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.20.3
>
> Attachments: 2097.patch
>
>
> HBASE-2037 added a bunch of fixes but also a deadlock:
> HRegion.put:
> {code}
> splitsAndClosesLock.readLock().lock();
> newScannerLock.writeLock().lock();
> {code}
> HRegion.close
> {code}
> newScannerLock.writeLock().lock();
> try {
> splitsAndClosesLock.writeLock().lock();
> {code}
> To recreate, start a PerformanceEvaluation on standalone and it happens roughly 75% of the time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.