[GitHub] mistercrunch commented on a change in pull request #4728: [sql_lab]Disabled run query button if sql query editor is empty

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4728: [sql_lab]Disabled run query button if sql query editor is empty
URL: https://github.com/apache/incubator-superset/pull/4728#discussion_r178712748
 
 

 ##########
 File path: superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
 ##########
 @@ -43,6 +44,7 @@ export default function RunQueryActionButton(props) {
       onClick={() => props.runQuery(true)}
       key="run-async-btn"
       tooltip={t('Run query asynchronously')}
+      disabled={!props.sql.trim()}
 
 Review comment:
   I'm confused as to why the linter isn't asking for `sql` to be in `propTypes`. I wanted to make sure it's entered as a `string` and can never be `null` through a defaultProps = ''

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services