svn commit: r768746 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Session.java

[kn...@apache.org]

Author: knopp
Date: Sun Apr 26 19:18:46 2009
New Revision: 768746

URL: http://svn.apache.org/viewvc?rev=768746&view=rev
Log:

Issue: WICKET-2130

Modified:
    wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Session.java

Modified: wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Session.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Session.java?rev=768746&r1=768745&r2=768746&view=diff
==============================================================================
--- wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Session.java (original)
+++ wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Session.java Sun Apr 26 19:18:46 2009
@@ -57,11 +57,10 @@
  * holds the Page. So {@link Component#getSession()} traverses the component hierarchy to the root
  * Page and then calls {@link Page#getSession()}.
  * 
- * <li><b>Access via Thread Local </b>- In the odd case where neither a RequestCycle nor a
- * Component is available, the currently active Session for the calling thread can be retrieved by
- * calling the static method Session.get(). This last form should only be used if the first two
- * forms cannot be used since thread local access can involve a potentially more expensive hash map
- * lookup.
+ * <li><b>Access via Thread Local </b>- In the odd case where neither a RequestCycle nor a Component
+ * is available, the currently active Session for the calling thread can be retrieved by calling the
+ * static method Session.get(). This last form should only be used if the first two forms cannot be
+ * used since thread local access can involve a potentially more expensive hash map lookup.
  * 
  * <li><b>Locale </b>- A session has a Locale property to support localization. The Locale for a
  * session can be set by calling {@link Session#setLocale(Locale)}. The Locale for a Session
@@ -103,9 +102,9 @@
  * <li><b>Removal </b>- Pages can be removed from the Session forcibly by calling remove(Page) or
  * removeAll(), although such an action should rarely be necessary.
  * 
- * <li><b>Flash Messages</b>- Flash messages are messages that are stored in session and are
- * removed after they are displayed to the user. Session acts as a store for these messages because
- * they can last across requests.
+ * <li><b>Flash Messages</b>- Flash messages are messages that are stored in session and are removed
+ * after they are displayed to the user. Session acts as a store for these messages because they can
+ * last across requests.
  * 
  * @author Jonathan Locke
  * @author Eelco Hillenius
@@ -388,8 +387,8 @@
 	 * <p>
 	 * By calling this method, the session will be bound (made not-temporary) if it was not bound
 	 * yet. It is useful for cases where you want to be absolutely sure this session object will be
-	 * available in next requests. If the session was already bound ({@link ISessionStore#lookup(Request) returns a session}),
-	 * this call will be a noop.
+	 * available in next requests. If the session was already bound (
+	 * {@link ISessionStore#lookup(Request) returns a session}), this call will be a noop.
 	 * </p>
 	 */
 	public final void bind()
@@ -1367,6 +1366,7 @@
 			for (int i = 0; i < touchedPages.size(); i++)
 			{
 				Page page = (Page)touchedPages.get(i);
+				page.detach();
 				page.getPageMap().put(page);
 				dirty = true;
 			}