You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aipiJuancho (via GitHub)" <gi...@apache.org> on 2026/09/22 14:00:45 UTC

[PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

aipiJuancho opened a new pull request, #44531:
URL: https://github.com/apache/superset/pull/44531

   ### SUMMARY
   
   Fixes #44530
   
   The vertical filter bar receives `clearAllTriggers`/`onClearAllComplete` from `FilterBar` but never forwards them to `<FilterControls>`, so the `clearAllTrigger` hook never reaches filter plugins. As a result, after "Clear all" a Select filter's local `useImmerReducer` state stays frozen at the last selection, and re-selecting the same value is discarded by the reducer's `JSON.stringify` equality guards (silent no-op; the "Apply filters" button stays disabled). `Horizontal.tsx` already forwards both props; this restores parity for the vertical bar and adds them to the `filterControls` `useMemo` deps so the memoized element is rebuilt when a clear-all trigger fires.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A (behavioral fix; repro steps and root-cause analysis in the linked issue)
   
   ### TESTING INSTRUCTIONS
   
   **Manual:** vertical filter bar + a Select filter → select a value → Apply → Clear all → re-select the same value → the tag appears and "Apply filters" enables.
   
   **Automated:** suggested addition to `FilterBar.test.tsx` — render the vertical bar, select a value, apply, click "Clear all", re-select the same value and assert the dataMask receives the new selection. Happy to add it to this PR if maintainers want it included.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #44530
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "aipiJuancho (via GitHub)" <gi...@apache.org>.
aipiJuancho commented on PR #44531:
URL: https://github.com/apache/superset/pull/44531#issuecomment-5890356388

   Good catch @rusackas — tidied in 5a9f9f3: the vertical test now calls `fetchMock.removeRoute('vertical-clear-chart-data')` at the end, exactly like the range-clear test above it.
   
   And the E2E you asked for is in 2f59849: a new scenario in `playwright/tests/dashboard/clear-all-filters.spec.ts` against the real backend, reusing that spec's fixture (chart + `birth_names` gender select filter, vertical bar):
   
   1. select `boy` → Apply, 2. Clear all → Apply, 3. re-select the very value Clear All removed → **assert Apply becomes enabled again** → Apply reaches the backend.
   
   That middle assertion is the regression: without the four-line forwarding, the Select plugin's local state stays pinned to `boy` after Clear all, the reducer discards the equal-valued re-selection, and Apply stays disabled. Same flow as the jest regression test, but end-to-end. `DashboardFilterBar.getApplyButton` became public (one word) so specs can assert the button state without duplicating the selector.
   
   `jest FilterBar.test.tsx` → 29/29, and the new spec lists cleanly under the repo's playwright config. PTAL — thanks for testing it locally and for the quick turnaround.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #44531:
URL: https://github.com/apache/superset/pull/44531#discussion_r4139180689


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx:
##########
@@ -774,6 +782,116 @@ test('Clear All in horizontal bar does not re-apply default values', async () =>
   updateDataMaskSpy.mockRestore();
 });
 
+test('Clear All in vertical bar lets the same value be re-selected afterwards', async () => {
+  // Vertical counterpart to the horizontal regression test above (issue
+  // #44530). `Vertical.tsx` used to destructure `clearAllTriggers`/
+  // `onClearAllComplete` without ever forwarding them to `FilterControls`
+  // (they were also missing from the `filterControls` `useMemo` deps), so
+  // filter plugins never received the clear-all trigger and their local
+  // `useImmerReducer` state stayed pinned to the last selection. The
+  // plugin's reducer discards any action whose new state stringifies equal
+  // to that pinned state, so re-selecting the value that Clear All removed
+  // was a silent no-op: Apply never re-enabled. Without the forwarding
+  // this test fails on the last assertion.
+  fetchMock.post(

Review Comment:
   The vertical regression test never uses this mock in a full-file run: `horizontal-clear-chart-data` from the preceding test is still the first catch-all route and wins declaration-order matching. Should the horizontal route be removed before this route is registered so this test exercises its own fixture?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #44531:
URL: https://github.com/apache/superset/pull/44531#discussion_r4135604600


##########
superset-frontend/playwright/tests/dashboard/clear-all-filters.spec.ts:
##########
@@ -160,3 +160,115 @@ testWithAssets(
     await applyAfterClearPromise;
   },
 );
+
+testWithAssets(
+  'Re-selecting the value Clear All removed re-enables Apply (#44530)',
+  async ({ page, testAssets }) => {
+    testWithAssets.setTimeout(TIMEOUT.SLOW_TEST);
+
+    const dataset = await getDatasetByName(page, DATASET_NAME);
+    if (!dataset) {
+      throw new Error(`Dataset ${DATASET_NAME} not found`);
+    }
+    const datasetId = dataset.id;
+
+    // Same fixture as the test above: one chart targeted by a gender
+    // native filter rendered in the vertical filter bar.
+    const chartParams = {
+      datasource: `${datasetId}__table`,
+      viz_type: 'big_number_total',
+      metric: 'count',
+      adhoc_filters: [],
+      header_font_size: 0.4,
+      subheader_font_size: 0.15,
+    };
+    const chartResp = await apiPost(page, 'api/v1/chart/', {
+      slice_name: `clear_all_reselect_${Date.now()}`,
+      viz_type: 'big_number_total',
+      datasource_id: datasetId,
+      datasource_type: 'table',
+      params: JSON.stringify(chartParams),
+    });
+    expect(chartResp.ok()).toBe(true);
+    const chartId = await extractIdFromResponse(chartResp);
+    testAssets.trackChart(chartId);
+
+    const positionJson = buildSingleRowDashboardLayout([
+      {
+        id: chartId,
+        sliceName: 'clear_all_reselect',
+        width: 6,
+        height: 50,
+      },
+    ]);
+
+    const jsonMetadata = buildFilterJsonMetadata({
+      chartsInScope: [chartId],
+      nativeFilters: [
+        buildSelectFilter({
+          datasetId,
+          column: FILTER_COLUMN,
+          chartsInScope: [chartId],
+          name: 'Gender',
+        }),
+      ],
+    });
+
+    const dashResp = await apiPostDashboard(page, {
+      dashboard_title: `clear_all_reselect_${Date.now()}`,
+      published: true,
+      position_json: JSON.stringify(positionJson),
+      json_metadata: JSON.stringify(jsonMetadata),
+    });
+    expect(dashResp.ok()).toBe(true);
+    const dashboardId = await extractIdFromResponse(dashResp);
+    testAssets.trackDashboard(dashboardId);
+
+    const linkResp = await apiPut(page, `api/v1/chart/${chartId}`, {
+      dashboards: [dashboardId],
+    });
+    expect(linkResp.ok()).toBe(true);
+
+    const dashboardPage = new DashboardPage(page);
+    await dashboardPage.gotoById(dashboardId);
+    await dashboardPage.waitForLoad({ timeout: TIMEOUT.SLOW_TEST });
+    await dashboardPage.waitForChartsToLoad();
+    const filterBar = await dashboardPage.waitForFilterBar();

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Duplicated dashboard fixture setup</b></div>
   <div id="fix">
   
   This new test re-implements the whole dashboard fixture inline (dataset lookup, chart POST, `buildSingleRowDashboardLayout`, `buildFilterJsonMetadata`, dashboard POST, chart link) — the same sequence already exported as `createDashboardWithCharts` in `./dashboard-test-helpers` and duplicated in the sibling test above. Reusing the helper removes ~70 duplicated lines and keeps the fixture in one place.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #d6c4df</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44531:
URL: https://github.com/apache/superset/pull/44531#discussion_r4114138250


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx:
##########
@@ -616,6 +620,10 @@ test('Clear All stages filter_range clear with [null, null], dispatched on Apply
     filterState: { value: [null, null], validateStatus: undefined },
     extraFormData: {},
   });
+  // Scope the catch-all chart/data mock to this test: fetch-mock matches
+  // routes in declaration order, so an unscoped route here would shadow the
+  // mocks declared by the tests that follow.
+  fetchMock.removeRoute('range-clear-chart-data');

Review Comment:
   **Suggestion:** Route removal occurs only after the assertions, so any failed assertion leaves the catch-all route installed and can corrupt subsequent tests.
   
   **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Rarely` · 🏷️ `Missing cleanup`
   
   [![Use CodeAnt Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [![Fix in Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ac9f5c3fe27d4da9bd0c1cae95e187e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [![Fix in VSCode Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ac9f5c3fe27d4da9bd0c1cae95e187e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx
   **Line:** 626:626
   **Comment:**
   	*Missing Cleanup: Route removal occurs only after the assertions, so any failed assertion leaves the catch-all route installed and can corrupt subsequent tests.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44531&comment_hash=76aaa7aa6771c8d77b0725e93825481a7f97f6d7f3fe5b460db053c2bdd2467a&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44531&comment_hash=76aaa7aa6771c8d77b0725e93825481a7f97f6d7f3fe5b460db053c2bdd2467a&reaction=dislike'>👎</a>



##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx:
##########
@@ -774,6 +782,115 @@ test('Clear All in horizontal bar does not re-apply default values', async () =>
   updateDataMaskSpy.mockRestore();
 });
 
+test('Clear All in vertical bar lets the same value be re-selected afterwards', async () => {
+  // Vertical counterpart to the horizontal regression test above (issue
+  // #44530). `Vertical.tsx` used to destructure `clearAllTriggers`/
+  // `onClearAllComplete` without ever forwarding them to `FilterControls`
+  // (they were also missing from the `filterControls` `useMemo` deps), so
+  // filter plugins never received the clear-all trigger and their local
+  // `useImmerReducer` state stayed pinned to the last selection. The
+  // plugin's reducer discards any action whose new state stringifies equal
+  // to that pinned state, so re-selecting the value that Clear All removed
+  // was a silent no-op: Apply never re-enabled. Without the forwarding
+  // this test fails on the last assertion.
+  fetchMock.post(
+    'glob:*/api/v1/chart/data',
+    {
+      result: [
+        {
+          data: [{ test_column: 'East' }, { test_column: 'West' }],
+          colnames: ['test_column'],
+          coltypes: [1],
+        },
+      ],
+    },
+    { name: 'vertical-clear-chart-data' },
+  );

Review Comment:
   **Suggestion:** The catch-all route remains registered after this test succeeds, so later chart requests can receive the East/West fixture and become order-dependent.
   
   **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Often` · 🏷️ `Missing cleanup`
   
   [![Use CodeAnt Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [![Fix in Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3f7e54852f9341a0b521f7d827090d77&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [![Fix in VSCode Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3f7e54852f9341a0b521f7d827090d77&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx
   **Line:** 796:808
   **Comment:**
   	*Missing Cleanup: The catch-all route remains registered after this test succeeds, so later chart requests can receive the East/West fixture and become order-dependent.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44531&comment_hash=c0f74c33d33c5b2dfe58acf0f819adba236a3f7931caac8936aa641604ee1428&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44531&comment_hash=c0f74c33d33c5b2dfe58acf0f819adba236a3f7931caac8936aa641604ee1428&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44531:
URL: https://github.com/apache/superset/pull/44531


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44531:
URL: https://github.com/apache/superset/pull/44531#issuecomment-5777892009

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44531:
URL: https://github.com/apache/superset/pull/44531#issuecomment-5890391893

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 2f598492886547be3e5e4342694c6ee2677f6f28 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6abbaf6de8e45d000727a9ec |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44531--superset-docs-preview.netlify.app](https://deploy-preview-44531--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ0NTMxLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.oPkWWkcyHTYDRchVnGWlmOX-6z162o2C_hekC8yRflE)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctBCoAgEADAv-w5SaKy-kHPWHUtYUtZJIro73mby7yQJR25wALQgBU83V4d4t1eJCU6ZBUiFxKLohwTCjKrInHbSGrxlDk9q69pRGsxjJ4m6gevtTadwZkcfD8) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-44531--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "aipiJuancho (via GitHub)" <gi...@apache.org>.
aipiJuancho commented on PR #44531:
URL: https://github.com/apache/superset/pull/44531#issuecomment-5852750476

   Thanks @rusackas! Rebased onto current master (`b10851d`) — CI should be clear now, as you predicted.
   
   Also took you up on the regression test (`ba90c05`): a vertical-bar test in `FilterBar.test.tsx` that runs the exact user flow — Clear all → Apply → re-select the same value — and asserts Apply re-enables. Verified it **fails without the forwarding fix** (28 pass, only this one fails: the Select plugin's local reducer stays pinned and discards the re-selection as a no-op) and passes with it.
   
   One incidental fix in the same file: the `filter_range` test's catch-all `chart/data` mock was registered unnamed, and fetch-mock v12 matches routes in declaration order — so it shadowed the mocks of every later test (the horizontal clear-all test was passing partly vacuously as a result). It is now named and removed at the end of that test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #44531:
URL: https://github.com/apache/superset/pull/44531#issuecomment-5883154606

   Thanks for the rebase and the regression test, @aipiJuancho! One thing before this merges though: codeant's flagged that the new vertical test never calls `fetchMock.removeRoute` for `vertical-clear-chart-data`, unlike the range-clear test right above it. Mind tidying that up the same way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44531:
URL: https://github.com/apache/superset/pull/44531#issuecomment-5893428468

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44531:
URL: https://github.com/apache/superset/pull/44531#issuecomment-5853978403

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): forward clearAllTriggers from vertical filter bar to FilterControls [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44531:
URL: https://github.com/apache/superset/pull/44531#issuecomment-5852828871

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44531?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 81.13%. Comparing base ([`eb2ffa2`](https://app.codecov.io/gh/apache/superset/commit/eb2ffa28ccf7dfa4f00a6b998c1567a83a3b051d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ba90c05`](https://app.codecov.io/gh/apache/superset/commit/ba90c052762b422625540f0bdeee52a5b4d9c841?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #44531   +/-   ##
   =======================================
     Coverage   81.12%   81.13%           
   =======================================
     Files        2956     2956           
     Lines      178434   178434           
     Branches    41339    41339           
   =======================================
   + Hits       144762   144779   +17     
   + Misses      30967    30950   -17     
     Partials     2705     2705           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/44531/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/44531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.52% <ø> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44531?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org