You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "wuchong (via GitHub)" <gi...@apache.org> on 2026/01/11 10:09:50 UTC
[I] Use `Schema.Builder#fromSchema` in SchemaUpdate [fluss]
wuchong opened a new issue, #2344:
URL: https://github.com/apache/fluss/issues/2344
### Search before asking
- [x] I searched in the [issues](https://github.com/apache/fluss/issues) and found nothing similar.
### Description
Currently, `SchemaUpdate` maintains schema members (primary keys, columns, auto-incr fields), which is very error-prone, leading to missing schema members when we evolve the schema structure and resulting in a broken schema after schema evolution.
I suggest to directly maintain `Schema.Builder` in `SchemaUpdate` and delegating all schema changes to `Schema.Builder`. This help us to only maintain one logic of schema building and validation. 降低出问题的可能性。
Besides, the `Schema.Builder#fromSchema` should also be updated if needed.
### Willingness to contribute
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Use `Schema.Builder#fromSchema` in SchemaUpdate [fluss]
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on issue #2344:
URL: https://github.com/apache/fluss/issues/2344#issuecomment-3765404289
Hi @Prajwal-banakar , I assigned this issue to you. I don't think there are any edge cases, but we may need some updates so the `SchemaBuilder` if existing API is not sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Use `Schema.Builder#fromSchema` in SchemaUpdate [fluss]
Posted by "Prajwal-banakar (via GitHub)" <gi...@apache.org>.
Prajwal-banakar commented on issue #2344:
URL: https://github.com/apache/fluss/issues/2344#issuecomment-3772941918
Hi @wuchong ,
I have refactored SchemaUpdate to directly maintain a Schema.Builder and delegate all schema changes to it, as suggested. I've also updated Schema.Builder#fromSchema and added a getColumn helper to the builder to ensure the API is sufficient for this delegation.
Ready for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Use `Schema.Builder#fromSchema` in SchemaUpdate [fluss]
Posted by "loserwang1024 (via GitHub)" <gi...@apache.org>.
loserwang1024 closed issue #2344: Use `Schema.Builder#fromSchema` in SchemaUpdate
URL: https://github.com/apache/fluss/issues/2344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Use `Schema.Builder#fromSchema` in SchemaUpdate [fluss]
Posted by "Prajwal-banakar (via GitHub)" <gi...@apache.org>.
Prajwal-banakar commented on issue #2344:
URL: https://github.com/apache/fluss/issues/2344#issuecomment-3737600426
Hi @wuchong , I'm interested in working on this issue as a contributor. I understand the goal is to delegate schema changes to Schema.Builder. Are there any specific edge cases regarding primary keys or auto-increment fields I should be aware of before I start refactoring SchemaUpdate? If not, I'd love to take this on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org