You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/06/30 23:00:10 UTC

[PR] Add Grails 8 upgrade skill [grails-core]

jamesfredley opened a new pull request, #15798:
URL: https://github.com/apache/grails-core/pull/15798

   ## Summary
   
   - Add a `grails-8-upgrade` project skill built from the Grails 8 upgrade guide and related docs.
   - Cover Java, Gradle, Spring Boot 4, Micronaut, Jackson 3, Hibernate/GORM, content negotiation, TagLib, testing, and plugin compatibility migration areas.
   - List the new skill in `AGENTS.md` so future agents know when to load it.
   
   ## Verification
   
   - `git diff --check origin/8.0.x...HEAD`
   - Markdown content/front matter check for `.agents/skills/grails-8-upgrade/SKILL.md`
   - Review gate: Oracle and Codex green for diff hash `8d205d1c3964dc5f717c9080ef47c488e88be4a0`
   
   Note: `lsp_diagnostics` was attempted for both changed markdown files, but no Markdown LSP is configured in this environment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Grails 8 upgrade skill [grails-core]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #15798:
URL: https://github.com/apache/grails-core/pull/15798#issuecomment-4848611598

   <!-- Bito Reply -->
   The suggested updates to the documentation paths are accurate. The files `grails-doc/src/en/ref/Dependency Versions.adoc` and `grails-doc/src/en/guide/conf/micronaut.adoc` are the correct in-tree locations for the information previously referenced by the non-existent paths. Updating these references will ensure the skill remains accurate and actionable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Grails 8 upgrade skill [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #15798:
URL: https://github.com/apache/grails-core/pull/15798


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Grails 8 upgrade skill [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #15798:
URL: https://github.com/apache/grails-core/pull/15798#discussion_r3502809667


##########
.agents/skills/grails-8-upgrade/SKILL.md:
##########
@@ -0,0 +1,336 @@
+---
+name: grails-8-upgrade
+description: Guide for upgrading Grails applications from Grails 7.x to Grails 8, covering Java 21, Spring Boot 4.1, Spring Framework 7, dependency management, Micronaut, Jackson 3, Hibernate 7, TagLibs, testing, content negotiation, and validation behavior changes
+license: Apache-2.0
+---
+
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements; and to You under the Apache License, Version 2.0.
+-->
+
+## What I Do
+
+- Guide upgrades of Grails applications from Grails 7.x to Grails 8.
+- Turn the Grails 8 upgrade guide into a practical migration checklist.
+- Identify Spring Boot 4.1, Spring Framework 7, Jackson 3, Gradle platform, Micronaut, Hibernate, TagLib, testing, validation, and content negotiation changes that can break an application.
+- Keep migration work focused on public application behavior, not internal Grails framework implementation details.
+
+## When to Use Me
+
+Activate this skill when:
+
+- Updating an application to Grails 8.
+- Reviewing a Grails 8 upgrade branch or pull request.
+- Fixing tests, build failures, runtime failures, or behavior changes after moving from Grails 7.x to Grails 8.
+- Deciding whether an upgrade should remain on Hibernate 5 or opt in to Hibernate 7.
+- Updating application build files, configuration, custom Spring Boot integration, TagLibs, JSON rendering, or content negotiation behavior for Grails 8.
+
+## Primary Sources
+
+Use these repository docs as the source of truth before changing an application:
+
+| Path | Use for |
+|------|---------|
+| `grails-doc/src/en/guide/upgrading/upgrading80x.adoc` | Main Grails 7 to Grails 8 upgrade guide |
+| `grails-doc/src/en/guide/introduction/whatsNew.adoc` | Grails 8 feature and platform overview |
+| `grails-doc/src/en/guide/introduction/whatsNew/dependencyUpgrades.adoc` | Current platform dependency baseline |
+| `grails-doc/src/en/ref/Versions/Grails BOM.adoc` | Default BOM dependency matrix |
+| `grails-doc/src/en/ref/Versions/Grails BOM Micronaut.adoc` | Micronaut BOM dependency matrix |
+| `grails-doc/src/en/guide/conf/micronaut.adoc` | Micronaut BOM and JDK 25 requirements |

Review Comment:
   Thanks, this was legitimate. I updated the source table in 37e2421868 to use the tracked `grails-doc/src/en/ref/Dependency Versions.adoc` reference and the existing Micronaut guide for the Micronaut BOM details.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Grails 8 upgrade skill [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15798:
URL: https://github.com/apache/grails-core/pull/15798#issuecomment-4848952760

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 10934744b7d409e5471ca46599a6e9b9b4c260e6
   ▶️ Tests:  34445 executed
   ⚪️ Checks: 45/45 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Grails 8 upgrade skill [grails-core]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #15798:
URL: https://github.com/apache/grails-core/pull/15798#discussion_r3502305403


##########
.agents/skills/grails-8-upgrade/SKILL.md:
##########
@@ -0,0 +1,336 @@
+---
+name: grails-8-upgrade
+description: Guide for upgrading Grails applications from Grails 7.x to Grails 8, covering Java 21, Spring Boot 4.1, Spring Framework 7, dependency management, Micronaut, Jackson 3, Hibernate 7, TagLibs, testing, content negotiation, and validation behavior changes
+license: Apache-2.0
+---
+
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements; and to You under the Apache License, Version 2.0.
+-->
+
+## What I Do
+
+- Guide upgrades of Grails applications from Grails 7.x to Grails 8.
+- Turn the Grails 8 upgrade guide into a practical migration checklist.
+- Identify Spring Boot 4.1, Spring Framework 7, Jackson 3, Gradle platform, Micronaut, Hibernate, TagLib, testing, validation, and content negotiation changes that can break an application.
+- Keep migration work focused on public application behavior, not internal Grails framework implementation details.
+
+## When to Use Me
+
+Activate this skill when:
+
+- Updating an application to Grails 8.
+- Reviewing a Grails 8 upgrade branch or pull request.
+- Fixing tests, build failures, runtime failures, or behavior changes after moving from Grails 7.x to Grails 8.
+- Deciding whether an upgrade should remain on Hibernate 5 or opt in to Hibernate 7.
+- Updating application build files, configuration, custom Spring Boot integration, TagLibs, JSON rendering, or content negotiation behavior for Grails 8.
+
+## Primary Sources
+
+Use these repository docs as the source of truth before changing an application:
+
+| Path | Use for |
+|------|---------|
+| `grails-doc/src/en/guide/upgrading/upgrading80x.adoc` | Main Grails 7 to Grails 8 upgrade guide |
+| `grails-doc/src/en/guide/introduction/whatsNew.adoc` | Grails 8 feature and platform overview |
+| `grails-doc/src/en/guide/introduction/whatsNew/dependencyUpgrades.adoc` | Current platform dependency baseline |
+| `grails-doc/src/en/ref/Versions/Grails BOM.adoc` | Default BOM dependency matrix |
+| `grails-doc/src/en/ref/Versions/Grails BOM Micronaut.adoc` | Micronaut BOM dependency matrix |
+| `grails-doc/src/en/guide/conf/micronaut.adoc` | Micronaut BOM and JDK 25 requirements |

Review Comment:
   The Primary Sources table references `grails-doc/src/en/ref/Versions/Grails BOM.adoc` and `.../Grails BOM Micronaut.adoc`, but `grails-doc/src/en/ref/Versions/` does not exist in this repo. The in-tree BOM reference doc is `grails-doc/src/en/ref/Dependency Versions.adoc`, and `grails-doc/src/en/guide/conf/micronaut.adoc` covers the Micronaut BOM usage (and links to the Micronaut dependency table). Updating these paths will keep the skill actionable for agents.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Grails 8 upgrade skill [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #15798:
URL: https://github.com/apache/grails-core/pull/15798#issuecomment-4855507893

   Will work on PR to publish each skill separately to https://www.skillsjars.com/.  I think that is possible and potentially a good path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Grails 8 upgrade skill [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15798:
URL: https://github.com/apache/grails-core/pull/15798#issuecomment-4849938045

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 37e2421868b328d4e66bfac32da88f27225442ed
   ▶️ Tests:  31936 executed
   ⚪️ Checks: 44/44 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Grails 8 upgrade skill [grails-core]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #15798:
URL: https://github.com/apache/grails-core/pull/15798#issuecomment-4848705264

   ## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/15798?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 49.4560%. Comparing base ([`a326766`](https://app.codecov.io/gh/apache/grails-core/commit/a3267664f10245cc7d7d94c90701fba97155b5b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1093474`](https://app.codecov.io/gh/apache/grails-core/commit/10934744b7d409e5471ca46599a6e9b9b4c260e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/grails-core/pull/15798/graphs/tree.svg?width=650&height=150&src=pr&token=qJrryhpk7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/grails-core/pull/15798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@              Coverage Diff              @@
   ##                8.0.x     #15798   +/-   ##
   =============================================
     Coverage     49.4560%   49.4560%           
     Complexity      16640      16640           
   =============================================
     Files            1944       1944           
     Lines           92379      92379           
     Branches        16130      16130           
   =============================================
     Hits            45687      45687           
     Misses          39593      39593           
     Partials         7099       7099           
   ```
   [see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/15798/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org