You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Will Glass-Husain (JIRA)" <ji...@apache.org> on 2006/09/21 08:44:22 UTC
[jira] Commented: (VELOCITY-459) localscope doesn't allow get to
leak
[ http://issues.apache.org/jira/browse/VELOCITY-459?page=comments#action_12436445 ]
Will Glass-Husain commented on VELOCITY-459:
--------------------------------------------
Thanks for reporting this and submitting a patch. Does "ant test" pass? We should get this into 1.5.
Is this related to Velocity-262?
> localscope doesn't allow get to leak
> ------------------------------------
>
> Key: VELOCITY-459
> URL: http://issues.apache.org/jira/browse/VELOCITY-459
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.5
> Reporter: Stephen Haberman
> Fix For: 1.5
>
> Attachments: localscopeGetFix.diff
>
>
> In short, we wanted "localscope" on for macros due to some recursion. However, this meant that both puts /and/ gets only use the localscope.
> For gets this seems overly restrictive--if I set "foo=bar" in my base VelocityContext, and then get into my macro, it should be able to reach that "foo" even if it can't overwrite it.
> The attached patch relaxes the "VMContext.get" to let it check first the local scope and then the inner scope. Included is a test that makes sure an "outsideVar" is accessible from VMContext even if localscope is on.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org