[GitHub] rdblue commented on a change in pull request #23714: [SPARK-26744][SQL]Support schema validation in FileDataSourceV2 framework

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #23714: [SPARK-26744][SQL]Support schema validation in FileDataSourceV2 framework
URL: https://github.com/apache/spark/pull/23714#discussion_r256649647
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcScan.scala
 ##########
 @@ -40,4 +40,10 @@ case class OrcScan(
     OrcPartitionReaderFactory(sparkSession.sessionState.conf, broadcastedConf,
       dataSchema, fileIndex.partitionSchema, readSchema)
   }
+
+  override def supportDataType(dataType: DataType): Boolean = {
+    OrcDataSourceV2.supportDataType(dataType)
+  }
+
+  override def toString: String = "ORC"
 
 Review comment:
   There is much more useful information in this class than just the file format name. This should use a `formatName` method instead so that `toString` can be used to show the object itself when debugging or logging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org