[GitHub] [accumulo] keith-turner commented on a change in pull request #1413: add choosable() to VolumeChooser and VolumeManager interfaces.

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1413: add choosable() to VolumeChooser and VolumeManager interfaces.
URL: https://github.com/apache/accumulo/pull/1413#discussion_r343688702
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java
 ##########
 @@ -44,6 +44,20 @@
    */
   String choose(VolumeChooserEnvironment env, String[] options) throws VolumeChooserException;
 
+  /**
+   * Return all volumes from options that are appropriate for the given environment.
+   *
+   * @param env
+   *          the server environment provided by the calling framework
+   * @param options
+   *          the list of volumes to choose from
+   * @return array of valid options
+   * @throws VolumeChooserException
+   *           if there is an error choosing (this is a RuntimeException); this does not preclude
+   *           other RuntimeExceptions from occurring
+   */
 
 Review comment:
   Would be nice to add a `@since 2.1.0` tag

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services