You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ChaladiMohanVamsi (via GitHub)" <gi...@apache.org> on 2023/09/11 16:32:37 UTC

[GitHub] [iceberg] ChaladiMohanVamsi commented on a diff in pull request #8533: AWS: Throw relevant exception at namespaceExists check usage in Glue Catalog

ChaladiMohanVamsi commented on code in PR #8533:
URL: https://github.com/apache/iceberg/pull/8533#discussion_r1321804294


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -524,7 +529,11 @@ public Map<String, String> loadNamespaceMetadata(Namespace namespace)
 
   @Override
   public boolean dropNamespace(Namespace namespace) throws NamespaceNotEmptyException {
-    namespaceExists(namespace);
+    // check if namespace exists
+    if (!namespaceExists(namespace)) {

Review Comment:
   @munendrasn Thanks for pointing that out. Made the change to return false in the case of dropNamespace.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org