You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "mosmeh (via GitHub)" <gi...@apache.org> on 2023/01/28 09:43:46 UTC

[GitHub] [hbase] mosmeh commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

mosmeh commented on PR #4997:
URL: https://github.com/apache/hbase/pull/4997#issuecomment-1407357024

   Thank you, I was not aware of [HBASE-27463](https://issues.apache.org/jira/browse/HBASE-27463). The PR https://github.com/apache/hbase/pull/4863 does seem to address [HBASE-24781](https://issues.apache.org/jira/browse/HBASE-24781) too.
   One my concern is that we would lose accumulated metrics if we clear and re-initialize metrics.
   This PR avoids that by not calling `singleSourceSource.clear()`.
   If this is not a problem, then I think we can close this ticket (and this PR) as being resolved by HBASE-27463.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org