You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "codope (via GitHub)" <gi...@apache.org> on 2025/04/07 11:16:02 UTC
[PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
codope opened a new pull request, #13097:
URL: https://github.com/apache/hudi/pull/13097
### Change Logs
Column stats creation fails when a decimal field with precision exceeds the max limit.
```
org.apache.avro.AvroTypeException: Cannot encode decimal with precision 35 as max precision 30. This is after safely adjusting scale from 0 to required 15
at org.apache.hudi.metadata.HoodieTableMetadataUtil.tryUpcastDecimal(HoodieTableMetadataUtil.java:1833)
at org.apache.hudi.avro.HoodieAvroUtils.wrapValueIntoAvro(HoodieAvroUtils.java:1464)
at org.apache.hudi.metadata.HoodieMetadataPayload.createColumnStatsRecord(HoodieMetadataPayload.java:523)
at org.apache.hudi.metadata.HoodieMetadataPayload.lambda$createColumnStatsRecords$5(HoodieMetadataPayload.java:497)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
```
This patch simply skip building stats for such fields instead of blocking ingestion.
### Impact
Skip building stats for decimal field with very high precision instead of blocking ingestion.
### Risk level (write none, low medium or high below)
low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2792116568
succeeded - https://dev.azure.com/apachehudi/hudi-oss-ci/_build/results?buildId=4772&view=results
<img width="1499" alt="Screenshot 2025-04-10 at 2 51 51 PM" src="https://github.com/user-attachments/assets/3b1b01e8-2196-4b58-aa74-64fe480f63d5" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2785203626
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b41eaee6f6ca7000c51f3232ecf9f3755f89e41 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681)
* a718ff895e29160efced7280f03ef7141b81f8c0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2791450231
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2787960452
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a718ff895e29160efced7280f03ef7141b81f8c0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706)
* e504a55f4dd6948ef2fe70c22cf43c8e352a221e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2791483898
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"triggerType" : "PUSH"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2791450231",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2791483301",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128 UNKNOWN
* 0000 Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2788124365
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2791562463
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"triggerType" : "PUSH"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2791450231",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2791483301",
"triggerType" : "MANUAL"
}, {
"hash" : "1224312f8c83185e27c88a30b8243008e9ef59db",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1224312f8c83185e27c88a30b8243008e9ef59db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128 UNKNOWN
* 0000 Unknown: [CANCELED](TBD)
* 1224312f8c83185e27c88a30b8243008e9ef59db UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2787963457
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728",
"triggerID" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a718ff895e29160efced7280f03ef7141b81f8c0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706)
* e504a55f4dd6948ef2fe70c22cf43c8e352a221e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2791453030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"triggerType" : "PUSH"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2791450231",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128 UNKNOWN
* 0000 Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13097:
URL: https://github.com/apache/hudi/pull/13097#discussion_r2031952928
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1907,6 +1908,19 @@ private static Double castToDouble(Object val) {
public static boolean isColumnTypeSupported(Schema schema, Option<HoodieRecordType> recordType) {
Schema schemaToCheck = resolveNullableSchema(schema);
+ // Check for precision and scale if the schema has a logical decimal type.
+ LogicalType logicalType = schemaToCheck.getLogicalType();
+ if (logicalType != null && logicalType instanceof LogicalTypes.Decimal) {
+ LogicalTypes.Decimal decimalType = (LogicalTypes.Decimal) logicalType;
+ // The maximum allowed precision and scale as per the payload schema. See DecimalWrapper in HoodieMetadata.avsc:
+ // https://github.com/apache/hudi/blob/45dedd819e56e521148bde51a3dfa4e472ea70cd/hudi-common/src/main/avro/HoodieMetadata.avsc#L247
+ final int maxPrecision = 30;
+ final int maxScale = 15;
Review Comment:
Can these be moved to constants?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2782977680
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b41eaee6f6ca7000c51f3232ecf9f3755f89e41 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2783179708
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b41eaee6f6ca7000c51f3232ecf9f3755f89e41 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2791603615
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"triggerType" : "PUSH"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2791450231",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2791483301",
"triggerType" : "MANUAL"
}, {
"hash" : "1224312f8c83185e27c88a30b8243008e9ef59db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4772",
"triggerID" : "1224312f8c83185e27c88a30b8243008e9ef59db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128 UNKNOWN
* 0000 Unknown: [CANCELED](TBD)
* 1224312f8c83185e27c88a30b8243008e9ef59db Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4772)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2788196959
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728",
"triggerID" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* e504a55f4dd6948ef2fe70c22cf43c8e352a221e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728) Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2791808644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"triggerType" : "PUSH"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2791450231",
"triggerType" : "MANUAL"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2791483301",
"triggerType" : "MANUAL"
}, {
"hash" : "1224312f8c83185e27c88a30b8243008e9ef59db",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4772",
"triggerID" : "1224312f8c83185e27c88a30b8243008e9ef59db",
"triggerType" : "PUSH"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128 UNKNOWN
* 1224312f8c83185e27c88a30b8243008e9ef59db Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4772)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2791184693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728",
"triggerID" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "8cddec4a34c22a0c3545f774de5264b655607e81",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4737",
"triggerID" : "8cddec4a34c22a0c3545f774de5264b655607e81",
"triggerType" : "PUSH"
}, {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8cddec4a34c22a0c3545f774de5264b655607e81 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4737)
* 5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13097:
URL: https://github.com/apache/hudi/pull/13097#discussion_r2031957652
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1907,6 +1908,19 @@ private static Double castToDouble(Object val) {
public static boolean isColumnTypeSupported(Schema schema, Option<HoodieRecordType> recordType) {
Schema schemaToCheck = resolveNullableSchema(schema);
+ // Check for precision and scale if the schema has a logical decimal type.
+ LogicalType logicalType = schemaToCheck.getLogicalType();
+ if (logicalType != null && logicalType instanceof LogicalTypes.Decimal) {
+ LogicalTypes.Decimal decimalType = (LogicalTypes.Decimal) logicalType;
+ // The maximum allowed precision and scale as per the payload schema. See DecimalWrapper in HoodieMetadata.avsc:
+ // https://github.com/apache/hudi/blob/45dedd819e56e521148bde51a3dfa4e472ea70cd/hudi-common/src/main/avro/HoodieMetadata.avsc#L247
+ final int maxPrecision = 30;
+ final int maxScale = 15;
+ if (decimalType.getPrecision() > maxPrecision || decimalType.getScale() > maxScale) {
Review Comment:
The logic here is not correct. You need `decimalType.getPrecision() + (maxScale - decimalType.getScale())` > maxPrecision || decimalType.getScale() > maxScale)` so you account for the change in precision when the scale is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2785201644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b41eaee6f6ca7000c51f3232ecf9f3755f89e41 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681)
* a718ff895e29160efced7280f03ef7141b81f8c0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2788082903
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728",
"triggerID" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e504a55f4dd6948ef2fe70c22cf43c8e352a221e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2791483301
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2791451259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a8f95aaf921ea7a0d1a71d5ada7bc9f208f2128 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #13097:
URL: https://github.com/apache/hudi/pull/13097#discussion_r2034231049
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/metadata/TestHoodieTableMetadataUtil.java:
##########
@@ -652,6 +652,27 @@ public void testValidateDataTypeForPartitionStats() {
.name("dateField").type(dateFieldSchema).noDefault()
.endRecord();
assertTrue(HoodieTableMetadataUtil.isColumnTypeSupported(schema.getField("dateField").schema(), Option.empty()));
+
+ // Test for logical decimal type with allowed precision and scale
+ schema = Schema.create(Schema.Type.BYTES);
+ LogicalTypes.Decimal decimalType = LogicalTypes.decimal(30, 15);
+ decimalType.addToSchema(schema);
+ // Expect the column to be supported.
+ assertTrue(HoodieTableMetadataUtil.isColumnTypeSupported(schema, Option.of(HoodieRecord.HoodieRecordType.AVRO)));
+
+ // Test for logical decimal type with precision and scale exceeding the limit
Review Comment:
can you TAL. I have added them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2788125483
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728",
"triggerID" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* e504a55f4dd6948ef2fe70c22cf43c8e352a221e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728) Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #13097:
URL: https://github.com/apache/hudi/pull/13097#discussion_r2032364039
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1907,6 +1908,19 @@ private static Double castToDouble(Object val) {
public static boolean isColumnTypeSupported(Schema schema, Option<HoodieRecordType> recordType) {
Schema schemaToCheck = resolveNullableSchema(schema);
+ // Check for precision and scale if the schema has a logical decimal type.
+ LogicalType logicalType = schemaToCheck.getLogicalType();
+ if (logicalType != null && logicalType instanceof LogicalTypes.Decimal) {
+ LogicalTypes.Decimal decimalType = (LogicalTypes.Decimal) logicalType;
+ // The maximum allowed precision and scale as per the payload schema. See DecimalWrapper in HoodieMetadata.avsc:
+ // https://github.com/apache/hudi/blob/45dedd819e56e521148bde51a3dfa4e472ea70cd/hudi-common/src/main/avro/HoodieMetadata.avsc#L247
+ final int maxPrecision = 30;
+ final int maxScale = 15;
+ if (decimalType.getPrecision() > maxPrecision || decimalType.getScale() > maxScale) {
Review Comment:
thanks, i did not account for upscaling. Updated the condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2785355185
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a718ff895e29160efced7280f03ef7141b81f8c0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13097:
URL: https://github.com/apache/hudi/pull/13097#discussion_r2033830648
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/metadata/TestHoodieTableMetadataUtil.java:
##########
@@ -652,6 +652,27 @@ public void testValidateDataTypeForPartitionStats() {
.name("dateField").type(dateFieldSchema).noDefault()
.endRecord();
assertTrue(HoodieTableMetadataUtil.isColumnTypeSupported(schema.getField("dateField").schema(), Option.empty()));
+
+ // Test for logical decimal type with allowed precision and scale
+ schema = Schema.create(Schema.Type.BYTES);
+ LogicalTypes.Decimal decimalType = LogicalTypes.decimal(30, 15);
+ decimalType.addToSchema(schema);
+ // Expect the column to be supported.
+ assertTrue(HoodieTableMetadataUtil.isColumnTypeSupported(schema, Option.of(HoodieRecord.HoodieRecordType.AVRO)));
+
+ // Test for logical decimal type with precision and scale exceeding the limit
Review Comment:
We should have tests where just 1 or the other exceeds as well to ensure the scale condition is hit in our testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2782973582
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b41eaee6f6ca7000c51f3232ecf9f3755f89e41 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #13097:
URL: https://github.com/apache/hudi/pull/13097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2788831765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728",
"triggerID" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "8cddec4a34c22a0c3545f774de5264b655607e81",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8cddec4a34c22a0c3545f774de5264b655607e81",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e504a55f4dd6948ef2fe70c22cf43c8e352a221e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728) Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731)
* 8cddec4a34c22a0c3545f774de5264b655607e81 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2789275151
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728",
"triggerID" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "8cddec4a34c22a0c3545f774de5264b655607e81",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4737",
"triggerID" : "8cddec4a34c22a0c3545f774de5264b655607e81",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8cddec4a34c22a0c3545f774de5264b655607e81 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4737)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9262] Skip building stats for decimal field with very high precision [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13097:
URL: https://github.com/apache/hudi/pull/13097#issuecomment-2789072252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4681",
"triggerID" : "6b41eaee6f6ca7000c51f3232ecf9f3755f89e41",
"triggerType" : "PUSH"
}, {
"hash" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4706",
"triggerID" : "a718ff895e29160efced7280f03ef7141b81f8c0",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728",
"triggerID" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"triggerType" : "PUSH"
}, {
"hash" : "e504a55f4dd6948ef2fe70c22cf43c8e352a221e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731",
"triggerID" : "2788124365",
"triggerType" : "MANUAL"
}, {
"hash" : "8cddec4a34c22a0c3545f774de5264b655607e81",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4737",
"triggerID" : "8cddec4a34c22a0c3545f774de5264b655607e81",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e504a55f4dd6948ef2fe70c22cf43c8e352a221e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4728) Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4731)
* 8cddec4a34c22a0c3545f774de5264b655607e81 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4737)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org