Re: [PR] [fix](client) Handle empty S3 list page with more results in concurrent deletion scenario [doris]

["gavinchou (via GitHub)" <gi...@apache.org>]

gavinchou commented on code in PR #60332:
URL: https://github.com/apache/doris/pull/60332#discussion_r2752462742


##########
cloud/src/recycler/s3_obj_client.cpp:
##########
@@ -140,8 +140,11 @@ class S3ObjListIterator final : public ObjectListIterator {
                 const_cast<std::string&&>(outcome.GetResult().GetNextContinuationToken())));
 
         auto&& content = outcome.GetResult().GetContents();
-        DCHECK(!(has_more_ && content.empty()))
-                << has_more_ << ' ' << content.empty() << " request_id=" << request_id;
+        if (has_more_ && content.empty()) {

Review Comment:
   DCHECK(has_more_ && !req_.GetContinuationToken.empty()) << ...
   if (has_more_ && !req_.GetContinuationToken.empty()) {
   LOG(ERROR) <<  "impossible" ...
   has_more_ = false;
   }



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org