Re: [PR] THRIFT-5000: Restore Docker Official Image packaging [thrift]

["Jens-G (via GitHub)" <gi...@apache.org>]

Jens-G commented on PR #3421:
URL: https://github.com/apache/thrift/pull/3421#issuecomment-4392433803

   ### Code review
   
   Found 2 issues:
   
   1. `doc/ReleaseManagement.md` is listed in the `docker.yml` `paths:` trigger and in the dirty-tree guard in `generate-official-images-library.sh` — any unrelated edit to that doc file will trigger a full Docker CI run and block manifest generation until the working tree is clean again
   
   https://github.com/apache/thrift/blob/03fddc446f452089bae8ff418a292c20f26f4490/.github/workflows/docker.yml#L7-L15
   
   https://github.com/apache/thrift/blob/03fddc446f452089bae8ff418a292c20f26f4490/docker/generate-official-images-library.sh#L26-L31
   
   2. The per-entry `"maintained"` field written by `update.sh` is never read by any consumer — `generate-stackbrew-library.sh`, `test.sh`, and `generate-official-images-library.sh` all slice by the top-level `maintained_releases` count instead. Setting a version's `"maintained": false` in `versions.json` would have no effect.
   
   https://github.com/apache/thrift/blob/03fddc446f452089bae8ff418a292c20f26f4490/docker/update.sh#L119-L128
   
   https://github.com/apache/thrift/blob/03fddc446f452089bae8ff418a292c20f26f4490/docker/generate-stackbrew-library.sh#L34-L38
   
   🤖 Generated with [Claude Code](https://claude.ai/code)
   
   <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org