[jira] [Created] (OAK-4127) Cleanup creates new generation of tar file without removing any segments

["Michael Dürig (JIRA)" <ji...@apache.org>]

Michael Dürig created OAK-4127:
----------------------------------

             Summary: Cleanup creates new generation of tar file without removing any segments 
                 Key: OAK-4127
                 URL: https://issues.apache.org/jira/browse/OAK-4127
             Project: Jackrabbit Oak
          Issue Type: Bug
          Components: segmentmk
            Reporter: Michael Dürig
            Priority: Minor
             Fix For: 1.6


On some deployments I have seen tar files with a quite hight generation post-fix (e.g. 'v'). From the log files I could deduce that this particular tar file was rewritten multiple times without actually any segment being removed. 

I assume this is caused by the 25% [gain threshold | https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/TarReader.java#L789] not taking the sizes contributed by the index and the graph entries into account. 

We should try to come up with a test case validating above hypothesis. A fix should then be relatively straight forward: either include the sizes of these two entries in the calculation or skip further clean cycles if a file size drops below a certain size. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)