You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:59:22 UTC
Review Request 61357: Imported `libev` and `libevent` libraries.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61357/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
The complicated install steps are not necessary when the library is
imported properly, as CMake is aware of its exact location.
Diffs
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
Diff: https://reviews.apache.org/r/61357/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61357: Imported `libev` and `libevent` libraries.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61357/#review184435
-----------------------------------------------------------
Ship it!
May possibly squash into https://reviews.apache.org/r/61291/ before committing.
- Joseph Wu
On Aug. 7, 2017, 10:42 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61357/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 10:42 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The complicated install steps are not necessary when the library is
> imported properly, as CMake is aware of its exact location.
>
> Review: https://reviews.apache.org/r/61357
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
>
>
> Diff: https://reviews.apache.org/r/61357/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61357: Imported `libev` and `libevent` libraries.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61357/
-----------------------------------------------------------
(Updated Aug. 7, 2017, 10:42 a.m.)
Review request for mesos.
Changes
-------
Added OPENSSL_ROOT_DIR forwarding.
Repository: mesos
Description (updated)
-------
The complicated install steps are not necessary when the library is
imported properly, as CMake is aware of its exact location.
Review: https://reviews.apache.org/r/61357
Diffs (updated)
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
Diff: https://reviews.apache.org/r/61357/diff/2/
Changes: https://reviews.apache.org/r/61357/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer