[GitHub] philipmundt edited a comment on issue #5: SLING-8047 Flush response's buffer once request has been processed

[GitBox <gi...@apache.org>]

philipmundt edited a comment on issue #5: SLING-8047 Flush response's buffer once request has been processed 
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/5#issuecomment-441592353
 
 
   Hi @jsedding Thanks for your feedback. I've addressed most of your concerns except using the `BufferedWriter` as it would expect a `Writer` instead of an `OutputStream`. If required I could easily provide another test case that showcases the same behavior with e.g. a `StringWriter`.
   
   Edit: I tried to keep the mocking as minimal as possible. IMHO it will be hard to reduce it even further!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services