You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/06/17 22:21:28 UTC
Re: svn commit: r1136949 - in /subversion/trunk/subversion:
include/svn_client.h include/svn_wc.h libsvn_client/status.c libsvn_wc/status.c
On Fri, Jun 17, 2011 at 13:23, <cm...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/include/svn_client.h Fri Jun 17 17:23:59 2011
> @@ -2082,6 +2082,10 @@ typedef struct svn_client_status_t
> /** The absolute path to the node */
> const char *local_abspath;
>
> + /** The actual size of the working file on disk, or -1 if unknown
> + * (or if the item isn't a file at all). */
That should be SVN_INVALID_FILESIZE.
>...
> +++ subversion/trunk/subversion/include/svn_wc.h Fri Jun 17 17:23:59 2011
> @@ -3495,6 +3495,10 @@ typedef struct svn_wc_status3_t
> * (#svn_depth_unknown for files or when no depth is set) */
> svn_depth_t depth;
>
> + /** The actual size of the working file on disk, or -1 if unknown
> + * (or if the item isn't a file at all). */
Likewise.
>...
> +++ subversion/trunk/subversion/libsvn_wc/status.c Fri Jun 17 17:23:59 2011
> @@ -393,6 +393,8 @@ assemble_status(svn_wc_status3_t **statu
> svn_error_t *err;
> const char *repos_relpath;
> const char *repos_root_url;
> + svn_filesize_t filesize =
> + (dirent && (dirent->kind == svn_node_file)) ? dirent->filesize : -1;
And here.
>...
> @@ -729,6 +732,7 @@ assemble_unversioned(svn_wc_status3_t **
> /*stat->versioned = FALSE;*/
> stat->kind = svn_node_unknown; /* not versioned */
> stat->depth = svn_depth_unknown;
> + stat->filesize = -1;
> stat->node_status = svn_wc_status_none;
> stat->text_status = svn_wc_status_none;
> stat->prop_status = svn_wc_status_none;
And here.
Cheers,
-g
Re: svn commit: r1136949 - in /subversion/trunk/subversion: include/svn_client.h
include/svn_wc.h libsvn_client/status.c libsvn_wc/status.c
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 06/17/2011 04:21 PM, Greg Stein wrote:
> On Fri, Jun 17, 2011 at 13:23, <cm...@apache.org> wrote:
>> ...
>> +++ subversion/trunk/subversion/include/svn_client.h Fri Jun 17 17:23:59 2011
>> @@ -2082,6 +2082,10 @@ typedef struct svn_client_status_t
>> /** The absolute path to the node */
>> const char *local_abspath;
>>
>> + /** The actual size of the working file on disk, or -1 if unknown
>> + * (or if the item isn't a file at all). */
>
> That should be SVN_INVALID_FILESIZE.
[...]
r1137686 and r1137687. Thanks!
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: svn commit: r1136949 - in /subversion/trunk/subversion: include/svn_client.h
include/svn_wc.h libsvn_client/status.c libsvn_wc/status.c
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 06/17/2011 04:21 PM, Greg Stein wrote:
> On Fri, Jun 17, 2011 at 13:23, <cm...@apache.org> wrote:
>> ...
>> +++ subversion/trunk/subversion/include/svn_client.h Fri Jun 17 17:23:59 2011
>> @@ -2082,6 +2082,10 @@ typedef struct svn_client_status_t
>> /** The absolute path to the node */
>> const char *local_abspath;
>>
>> + /** The actual size of the working file on disk, or -1 if unknown
>> + * (or if the item isn't a file at all). */
>
> That should be SVN_INVALID_FILESIZE.
Ah! I suspected there had to be a less hacky sentinel value. Will fix.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand