You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dneuman64 <gi...@git.apache.org> on 2017/08/01 14:21:55 UTC
[GitHub] incubator-trafficcontrol issue #733: Add ability to copy url sig keys and fi...
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/733
A few things with this PR:
1) If I choose to copy URL Sig keys the "From which DS" drop down is never populated
2) It looks like the all of the buttons that used to be conditional (Manage SSL Keys, Manage Steering Assignments, Create URL Sig Keys, etc) are now always show.
3) Adding two more buttons creates some collisions with the close button depending upon the options you have chose.
4) I think it would be cleaner to have a "manage URL Sig Keys" button rather than a generate and a copy
This PR has been out there for a while and I have been promising to review and haven't so I think I am going to see if I can clean some of this up quickly and PR it back to you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---