You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/01/16 21:07:27 UTC
Review Request 29978: Parallel package installation under SLES
misbehaves
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29978/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Yurii Shylov.
Bugs: AMBARI-9120
https://issues.apache.org/jira/browse/AMBARI-9120
Repository: ambari
Description
-------
Both issues reproduce only under SLES SP3, and don't reproduce under SLES SP1
The first issue:
When installing second stack version in parallel, dependencies for the second stack version are not installed
The second issue:
When trying to install older stack version in parallel with newer stack version, zypper refuses to install packages even through it has been restricted to relevant repositories. Looks like we have to append concrete repo versions before asterisk at globs like hadoop_2_2_*
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java da6e680
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 83c8037
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 0ad56c8
Diff: https://reviews.apache.org/r/29978/diff/
Testing
-------
manual tests under SLES SP1 and SLES SP3. Installed only few basic services for now. Performing more full-pledged tests.
Unit tests pass except the unrelated test fail (also fails on trunk)
----------------------------------------------------------------------
Failed tests:
FAIL: test_prompt_db_properties_for_each_database_type (TestAmbariServer.TestAmbariServer)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/media/plextor/ambari/ambari-server/src/test/python/TestAmbariServer.py", line 2370, in test_prompt_db_properties_for_each_database_type
self.assertFalse(_ambari_server_.JDBC_POSTGRES_SCHEMA_PROPERTY in properties.propertyNames())
AssertionError: True is not false
----------------------------------------------------------------------
Total run:585
Total errors:0
Total failures:1
ERROR
Thanks,
Dmitro Lisnichenko
Re: Review Request 29978: Parallel package installation under SLES
misbehaves
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29978/#review68636
-----------------------------------------------------------
Ship it!
Ship It!
- Yurii Shylov
On Янв. 19, 2015, 5:04 п.п., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29978/
> -----------------------------------------------------------
>
> (Updated Янв. 19, 2015, 5:04 п.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-9120
> https://issues.apache.org/jira/browse/AMBARI-9120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Both issues reproduce only under SLES SP3, and don't reproduce under SLES SP1
>
> The first issue:
> When installing second stack version in parallel, dependencies for the second stack version are not installed
>
> The second issue:
> When trying to install older stack version in parallel with newer stack version, zypper refuses to install packages even through it has been restricted to relevant repositories. Looks like we have to append concrete repo versions before asterisk at globs like hadoop_2_2_*
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a33930d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 51cf340
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java da6e680
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 83c8037
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 0ad56c8
>
> Diff: https://reviews.apache.org/r/29978/diff/
>
>
> Testing
> -------
>
> manual tests under SLES SP1 and SLES SP3. Installed only few basic services for now. Performing more full-pledged tests.
>
> Unit tests pass except the unrelated test fail (also fails on trunk)
>
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_prompt_db_properties_for_each_database_type (TestAmbariServer.TestAmbariServer)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/media/plextor/ambari/ambari-server/src/test/python/TestAmbariServer.py", line 2370, in test_prompt_db_properties_for_each_database_type
> self.assertFalse(_ambari_server_.JDBC_POSTGRES_SCHEMA_PROPERTY in properties.propertyNames())
> AssertionError: True is not false
>
> ----------------------------------------------------------------------
> Total run:585
> Total errors:0
> Total failures:1
> ERROR
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 29978: Parallel package installation under SLES
misbehaves
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29978/
-----------------------------------------------------------
(Updated Jan. 19, 2015, 5:04 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Yurii Shylov.
Changes
-------
Addressed Jonathan's comments, also included fix for jira 'Versions: install operation text should be "Install version"'
Bugs: AMBARI-9120
https://issues.apache.org/jira/browse/AMBARI-9120
Repository: ambari
Description
-------
Both issues reproduce only under SLES SP3, and don't reproduce under SLES SP1
The first issue:
When installing second stack version in parallel, dependencies for the second stack version are not installed
The second issue:
When trying to install older stack version in parallel with newer stack version, zypper refuses to install packages even through it has been restricted to relevant repositories. Looks like we have to append concrete repo versions before asterisk at globs like hadoop_2_2_*
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a33930d
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 51cf340
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java da6e680
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 83c8037
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 0ad56c8
Diff: https://reviews.apache.org/r/29978/diff/
Testing
-------
manual tests under SLES SP1 and SLES SP3. Installed only few basic services for now. Performing more full-pledged tests.
Unit tests pass except the unrelated test fail (also fails on trunk)
----------------------------------------------------------------------
Failed tests:
FAIL: test_prompt_db_properties_for_each_database_type (TestAmbariServer.TestAmbariServer)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/media/plextor/ambari/ambari-server/src/test/python/TestAmbariServer.py", line 2370, in test_prompt_db_properties_for_each_database_type
self.assertFalse(_ambari_server_.JDBC_POSTGRES_SCHEMA_PROPERTY in properties.propertyNames())
AssertionError: True is not false
----------------------------------------------------------------------
Total run:585
Total errors:0
Total failures:1
ERROR
Thanks,
Dmitro Lisnichenko
Re: Review Request 29978: Parallel package installation under SLES
misbehaves
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29978/#review68483
-----------------------------------------------------------
Ship it!
Address Jonathan's comments, then Ship It
- Nate Cole
On Jan. 16, 2015, 3:07 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29978/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 3:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-9120
> https://issues.apache.org/jira/browse/AMBARI-9120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Both issues reproduce only under SLES SP3, and don't reproduce under SLES SP1
>
> The first issue:
> When installing second stack version in parallel, dependencies for the second stack version are not installed
>
> The second issue:
> When trying to install older stack version in parallel with newer stack version, zypper refuses to install packages even through it has been restricted to relevant repositories. Looks like we have to append concrete repo versions before asterisk at globs like hadoop_2_2_*
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java da6e680
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 83c8037
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 0ad56c8
>
> Diff: https://reviews.apache.org/r/29978/diff/
>
>
> Testing
> -------
>
> manual tests under SLES SP1 and SLES SP3. Installed only few basic services for now. Performing more full-pledged tests.
>
> Unit tests pass except the unrelated test fail (also fails on trunk)
>
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_prompt_db_properties_for_each_database_type (TestAmbariServer.TestAmbariServer)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/media/plextor/ambari/ambari-server/src/test/python/TestAmbariServer.py", line 2370, in test_prompt_db_properties_for_each_database_type
> self.assertFalse(_ambari_server_.JDBC_POSTGRES_SCHEMA_PROPERTY in properties.propertyNames())
> AssertionError: True is not false
>
> ----------------------------------------------------------------------
> Total run:585
> Total errors:0
> Total failures:1
> ERROR
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 29978: Parallel package installation under SLES
misbehaves
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29978/#review68480
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
<https://reviews.apache.org/r/29978/#comment112747>
You can just use slf4j here to do the logging; no need to complicate the statement with an extra String.format()
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py
<https://reviews.apache.org/r/29978/#comment112748>
differentl -> differently
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py
<https://reviews.apache.org/r/29978/#comment112749>
the -> there are
- Jonathan Hurley
On Jan. 16, 2015, 3:07 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29978/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 3:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-9120
> https://issues.apache.org/jira/browse/AMBARI-9120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Both issues reproduce only under SLES SP3, and don't reproduce under SLES SP1
>
> The first issue:
> When installing second stack version in parallel, dependencies for the second stack version are not installed
>
> The second issue:
> When trying to install older stack version in parallel with newer stack version, zypper refuses to install packages even through it has been restricted to relevant repositories. Looks like we have to append concrete repo versions before asterisk at globs like hadoop_2_2_*
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java da6e680
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 83c8037
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 0ad56c8
>
> Diff: https://reviews.apache.org/r/29978/diff/
>
>
> Testing
> -------
>
> manual tests under SLES SP1 and SLES SP3. Installed only few basic services for now. Performing more full-pledged tests.
>
> Unit tests pass except the unrelated test fail (also fails on trunk)
>
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_prompt_db_properties_for_each_database_type (TestAmbariServer.TestAmbariServer)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/media/plextor/ambari/ambari-server/src/test/python/TestAmbariServer.py", line 2370, in test_prompt_db_properties_for_each_database_type
> self.assertFalse(_ambari_server_.JDBC_POSTGRES_SCHEMA_PROPERTY in properties.propertyNames())
> AssertionError: True is not false
>
> ----------------------------------------------------------------------
> Total run:585
> Total errors:0
> Total failures:1
> ERROR
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 29978: Parallel package installation under SLES
misbehaves
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29978/#review68482
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 16, 2015, 3:07 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29978/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 3:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-9120
> https://issues.apache.org/jira/browse/AMBARI-9120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Both issues reproduce only under SLES SP3, and don't reproduce under SLES SP1
>
> The first issue:
> When installing second stack version in parallel, dependencies for the second stack version are not installed
>
> The second issue:
> When trying to install older stack version in parallel with newer stack version, zypper refuses to install packages even through it has been restricted to relevant repositories. Looks like we have to append concrete repo versions before asterisk at globs like hadoop_2_2_*
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java da6e680
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 83c8037
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 0ad56c8
>
> Diff: https://reviews.apache.org/r/29978/diff/
>
>
> Testing
> -------
>
> manual tests under SLES SP1 and SLES SP3. Installed only few basic services for now. Performing more full-pledged tests.
>
> Unit tests pass except the unrelated test fail (also fails on trunk)
>
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_prompt_db_properties_for_each_database_type (TestAmbariServer.TestAmbariServer)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/media/plextor/ambari/ambari-server/src/test/python/TestAmbariServer.py", line 2370, in test_prompt_db_properties_for_each_database_type
> self.assertFalse(_ambari_server_.JDBC_POSTGRES_SCHEMA_PROPERTY in properties.propertyNames())
> AssertionError: True is not false
>
> ----------------------------------------------------------------------
> Total run:585
> Total errors:0
> Total failures:1
> ERROR
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>