You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/21 11:19:09 UTC
[GitHub] [flink] beyond1920 opened a new pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero.
beyond1920 opened a new pull request #16219:
URL: https://github.com/apache/flink/pull/16219
## What is the purpose of the change
This pr aims to fix a bug in emit behavior of `GroupWindowAggregate` when input stream contains retraction. After updating, `GroupWindowAggregate` would not emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero.
## Brief change log
- Update constructors of `WindowOperator` and it's subclasses to including `inputCountIndex` which means index of input counter
- Update `StreamExecGroupWindowAggregate` to add `inputCountIndex` when create new `WindowOperator` instance.
## Verifying this change
- Existed ITCase in `GroupWindowITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "866820020",
"triggerType" : "MANUAL"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "870428834",
"triggerType" : "MANUAL"
}, {
"hash" : "3489a08c1478f37a8a5c52a1dee301ae30e70642",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3489a08c1478f37a8a5c52a1dee301ae30e70642",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234)
* 3489a08c1478f37a8a5c52a1dee301ae30e70642 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-868185126
@cshuo Would you please have a look at the pull request, thanks a lot. cc @godfreyhe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-870428834
@flinkbot run travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "866820020",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "866820020",
"triggerType" : "MANUAL"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "870428834",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad7ee4fd31094a6a1268b53dcc6b3a38895712f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-865641200
ci fails caused by [FLINK-23079](https://issues.apache.org/jira/browse/FLINK-23079)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-865641200
ci fails caused by [FLINK-23079](https://issues.apache.org/jira/browse/FLINK-23079)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-870428834
@flinkbot run travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864962044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "866820020",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864962044
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3489a08c1478f37a8a5c52a1dee301ae30e70642 (Thu Sep 23 17:56:35 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #16219:
URL: https://github.com/apache/flink/pull/16219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-871309944
@cshuo @godfreyhe Thanks for your review, I've address all your comments, please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad7ee4fd31094a6a1268b53dcc6b3a38895712f8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229)
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cshuo commented on a change in pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
cshuo commented on a change in pull request #16219:
URL: https://github.com/apache/flink/pull/16219#discussion_r661204898
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/GroupWindowITCase.scala
##########
@@ -412,10 +412,8 @@ class GroupWindowITCase(mode: StateBackendMode, useTimestampLtz: Boolean)
tEnv.sqlQuery(sql).toAppendStream[Row].addSink(sink)
Review comment:
nips: perhaps it's better to add some more agg calls besides `count(1)`, which happens to act as 'inputs counter' as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "866820020",
"triggerType" : "MANUAL"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "870428834",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #16219:
URL: https://github.com/apache/flink/pull/16219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "866820020",
"triggerType" : "MANUAL"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "870428834",
"triggerType" : "MANUAL"
}, {
"hash" : "3489a08c1478f37a8a5c52a1dee301ae30e70642",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19742",
"triggerID" : "3489a08c1478f37a8a5c52a1dee301ae30e70642",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3489a08c1478f37a8a5c52a1dee301ae30e70642 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19742)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864962044
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ad7ee4fd31094a6a1268b53dcc6b3a38895712f8 (Mon Jun 21 11:34:38 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #16219:
URL: https://github.com/apache/flink/pull/16219#discussion_r661111525
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/window/AggregateWindowOperator.java
##########
@@ -156,35 +160,55 @@ protected void compileGeneratedCode() {
@Override
protected void emitWindowResult(W window) throws Exception {
windowFunction.prepareAggregateAccumulatorForEmit(window);
+ RowData acc = aggWindowAggregator.getAccumulators();
RowData aggResult = aggWindowAggregator.getValue(window);
if (produceUpdates) {
Review comment:
Please add some tests to cover this branch
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/window/TableAggregateWindowOperator.java
##########
@@ -124,6 +128,9 @@ protected void compileGeneratedCode() {
@Override
protected void emitWindowResult(W window) throws Exception {
windowFunction.prepareAggregateAccumulatorForEmit(window);
- tableAggWindowAggregator.emitValue(window, (RowData) getCurrentKey(), collector);
+ RowData acc = tableAggWindowAggregator.getAccumulators();
+ if (!recordCounter.recordCountIsZero(acc)) {
Review comment:
please add some tests to cover this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad7ee4fd31094a6a1268b53dcc6b3a38895712f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229)
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "866820020",
"triggerType" : "MANUAL"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "870428834",
"triggerType" : "MANUAL"
}, {
"hash" : "3489a08c1478f37a8a5c52a1dee301ae30e70642",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19742",
"triggerID" : "3489a08c1478f37a8a5c52a1dee301ae30e70642",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234)
* 3489a08c1478f37a8a5c52a1dee301ae30e70642 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19742)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
}, {
"hash" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234",
"triggerID" : "cee3b72849481df178bd11ccb7b3dd9bd5dbea50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad7ee4fd31094a6a1268b53dcc6b3a38895712f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229)
* cee3b72849481df178bd11ccb7b3dd9bd5dbea50 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19234)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-864976559
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229",
"triggerID" : "ad7ee4fd31094a6a1268b53dcc6b3a38895712f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad7ee4fd31094a6a1268b53dcc6b3a38895712f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19229)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #16219:
URL: https://github.com/apache/flink/pull/16219#issuecomment-866820020
@flinkbot run travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #16219: [FLINK-22781][table-planner-blink] Fix bug in emit behavior of GroupWindowAggregate to skip emit window result if input stream of GroupWindowAggregate contains retraction and input counter of input records for current window is zero
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #16219:
URL: https://github.com/apache/flink/pull/16219#discussion_r661248071
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/window/TableAggregateWindowOperator.java
##########
@@ -124,6 +128,9 @@ protected void compileGeneratedCode() {
@Override
protected void emitWindowResult(W window) throws Exception {
windowFunction.prepareAggregateAccumulatorForEmit(window);
- tableAggWindowAggregator.emitValue(window, (RowData) getCurrentKey(), collector);
+ RowData acc = tableAggWindowAggregator.getAccumulators();
+ if (!recordCounter.recordCountIsZero(acc)) {
Review comment:
already covered by exisited `WindowOperatorContractTest#testAssignerWithMultipleWindowsForTableAggregate`.
If i didn't update `mockTableAggsHandleFunction`, it would return accumulator to null.
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/window/AggregateWindowOperator.java
##########
@@ -156,35 +160,55 @@ protected void compileGeneratedCode() {
@Override
protected void emitWindowResult(W window) throws Exception {
windowFunction.prepareAggregateAccumulatorForEmit(window);
+ RowData acc = aggWindowAggregator.getAccumulators();
RowData aggResult = aggWindowAggregator.getValue(window);
if (produceUpdates) {
Review comment:
1.`produceUpdate` is true and count decreases to 0 could be covered by new added `GroupWindowITCase#testWindowAggregateOnUpsertSourceWithAllowLateness`
2. `produceUpdate` is true and count always not 0 could be covered by existed `GroupWindowITCase#testMinMaxWithTumblingWindow`
3. `produceUpdate` is false could be covered by many existed `GroupWindowITCase#testWindowAggregateOnUpsertSource`
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/GroupWindowITCase.scala
##########
@@ -412,10 +412,8 @@ class GroupWindowITCase(mode: StateBackendMode, useTimestampLtz: Boolean)
tEnv.sqlQuery(sql).toAppendStream[Row].addSink(sink)
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org