You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/07/01 15:04:30 UTC
[GitHub] storm pull request #1535: STORM-1941 Nimbus discovery can fail when zookeepe...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1535
STORM-1941 Nimbus discovery can fail when zookeeper reconnect happens.
* delete ephemeral node first when reconnected handler is called
PR for 1.x: #1534
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1941
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1535.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1535
----
commit 5b19cf0ebdd2aef627aae1ee0edfd09574d55ca6
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-01T14:58:05Z
STORM-1941 Nimbus discovery can fail when zookeeper reconnect happens.
* delete ephemeral node first when reconnected handler is called
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1535: STORM-1941 Nimbus discovery can fail when zookeepe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1535: STORM-1941 Nimbus discovery can fail when zookeepe...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1535#discussion_r69409241
--- Diff: storm-core/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -219,6 +219,8 @@ public void stateChanged(CuratorFramework curatorFramework, ConnectionState conn
LOG.info("Connection state listener invoked, zookeeper connection state has changed to {}", connectionState);
if (connectionState.equals(ConnectionState.RECONNECTED)) {
LOG.info("Connection state has changed to reconnected so setting nimbuses entry one more time");
+ // explicit delete for ephmeral node to ensure this session creates the entry.
+ stateStorage.delete_node(ClusterUtils.nimbusPath(nimbusId));
--- End diff --
@harshach
This is for edge case for ephemeral node not deleted while session is closed.
Please refer http://issues.apache.org/jira/browse/STORM-1941.
I know it's odd but it is happening, and other article states this behavior.
https://www.box.com/blog/a-gotcha-when-using-zookeeper-ephemeral-nodes/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1535: STORM-1941 Nimbus discovery can fail when zookeeper recon...
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/1535
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1535: STORM-1941 Nimbus discovery can fail when zookeepe...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1535#discussion_r69408836
--- Diff: storm-core/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -219,6 +219,8 @@ public void stateChanged(CuratorFramework curatorFramework, ConnectionState conn
LOG.info("Connection state listener invoked, zookeeper connection state has changed to {}", connectionState);
if (connectionState.equals(ConnectionState.RECONNECTED)) {
LOG.info("Connection state has changed to reconnected so setting nimbuses entry one more time");
+ // explicit delete for ephmeral node to ensure this session creates the entry.
+ stateStorage.delete_node(ClusterUtils.nimbusPath(nimbusId));
--- End diff --
Aren't we using ephemeral node for this? If not I think we should do that no? Instead of manually deleting the node.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1535: STORM-1941 Nimbus discovery can fail when zookeeper recon...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1535
@HeartSaVioR makes sense. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---