You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/07/14 22:46:39 UTC

svn commit: r1891555 - in /poi/trunk/poi-integration/src/test/java/org/apache/poi/stress: OPCFileHandler.java XWPFFileHandler.java

Author: fanningpj
Date: Wed Jul 14 22:46:39 2021
New Revision: 1891555

URL: http://svn.apache.org/viewvc?rev=1891555&view=rev
Log:
try to fix failing tests

Modified:
    poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/OPCFileHandler.java
    poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XWPFFileHandler.java

Modified: poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/OPCFileHandler.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/OPCFileHandler.java?rev=1891555&r1=1891554&r2=1891555&view=diff
==============================================================================
--- poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/OPCFileHandler.java (original)
+++ poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/OPCFileHandler.java Wed Jul 14 22:46:39 2021
@@ -23,6 +23,10 @@ import java.io.File;
 import java.io.FileInputStream;
 import java.io.InputStream;
 import java.io.PushbackInputStream;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
 
 import org.apache.poi.openxml4j.opc.ContentTypes;
 import org.apache.poi.openxml4j.opc.OPCPackage;
@@ -31,17 +35,18 @@ import org.apache.poi.xwpf.usermodel.XWP
 import org.junit.jupiter.api.Test;
 
 class OPCFileHandler extends AbstractFileHandler {
+    private static final Set<String> EXPECTED_FAILURES = unmodifiableHashSet(
+            "document/truncated62886.docx"
+    );
+
     @Override
     public void handleFile(InputStream stream, String path) throws Exception {
         // ignore password protected files
         if (POIXMLDocumentHandler.isEncrypted(stream)) return;
 
-        OPCPackage p;
-        try {
-            p = OPCPackage.open(stream);
-        } catch (Exception e) {
-            throw new RuntimeException("Failed to open '" + path + "' as OPCPackage", e);
-        }
+        if (EXPECTED_FAILURES.contains(path)) return;
+
+        OPCPackage p = OPCPackage.open(stream);
 
         for (PackagePart part : p.getParts()) {
             if (part.getPartName().toString().equals("/docProps/core.xml")) {
@@ -75,4 +80,8 @@ class OPCFileHandler extends AbstractFil
 
         handleExtracting(file);
     }
+
+    private static Set<String> unmodifiableHashSet(String... a) {
+        return Collections.unmodifiableSet(new HashSet<>(Arrays.asList(a)));
+    }
 }

Modified: poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XWPFFileHandler.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XWPFFileHandler.java?rev=1891555&r1=1891554&r2=1891555&view=diff
==============================================================================
--- poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XWPFFileHandler.java (original)
+++ poi/trunk/poi-integration/src/test/java/org/apache/poi/stress/XWPFFileHandler.java Wed Jul 14 22:46:39 2021
@@ -26,25 +26,27 @@ import java.util.HashSet;
 import java.util.Set;
 
 import org.apache.poi.ooxml.POIXMLException;
-import org.apache.poi.openxml4j.opc.OPCPackage;
 import org.apache.poi.xwpf.usermodel.XWPFDocument;
 import org.junit.jupiter.api.Test;
 
 class XWPFFileHandler extends AbstractFileHandler {
+    private static final Set<String> EXPECTED_FAILURES = unmodifiableHashSet(
+            "document/truncated62886.docx"
+    );
 
     @Override
     public void handleFile(InputStream stream, String path) throws Exception {
         // ignore password protected files
         if (POIXMLDocumentHandler.isEncrypted(stream)) return;
 
+        if (EXPECTED_FAILURES.contains(path)) return;
+
         try (XWPFDocument doc = new XWPFDocument(stream)) {
             new POIXMLDocumentHandler().handlePOIXMLDocument(doc);
             POIXMLDocumentHandler.cursorRecursive(doc.getDocument());
         } catch (POIXMLException e) {
             Exception cause = (Exception)e.getCause();
             throw cause == null ? e : cause;
-        } catch (Exception e) {
-            throw new RuntimeException("Failed to open '" + path + "' as XWPFDocument", e);
         }
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org