You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/21 16:46:10 UTC

[GitHub] zentol opened a new pull request #6599: [FLINK-10150][metrics] Fix OperatorMetricGroup creation for Batch

zentol opened a new pull request #6599: [FLINK-10150][metrics] Fix OperatorMetricGroup creation for Batch
URL: https://github.com/apache/flink/pull/6599
 
 
   ## What is the purpose of the change
   
   This PR fixes a severe issue in the metric system where chained batch operators would always operate on the same `OperatorMetricGroup`. As a result most Flink-provided metrics were not exposed for chained operators at all, while other metrics, like task-level IO metrics, were render incorrect.
   
   The problem is that we used the tasks `VertexID` to identify operators; which is obviously identical for all operators in a chain. We now use the vertexID and operator name to identify them.
   
   ## Brief change log
   
   * fix identification in `TaskMetricGroup` by using both the ID and operator name
   * extend `MockEnvironment[Builder]` to allow the `TaskMetricGroup` to be set
   
   ## Verifying this change
   
   This change added tests:
   * ChainedOperatorsMetricTest
   * run a basic wordcount as described in the JIRA and verify the results via the UI/reporter of your choice
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services