You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Claudenw (via GitHub)" <gi...@apache.org> on 2024/06/24 12:15:53 UTC
[PR] [Collections-857] update bloom filter documentation [commons-collections]
Claudenw opened a new pull request, #508:
URL: https://github.com/apache/commons-collections/pull/508
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Collections-857] update bloom filter documentation [commons-collections]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #508:
URL: https://github.com/apache/commons-collections/pull/508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Collections-857] update bloom filter documentation [commons-collections]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #508:
URL: https://github.com/apache/commons-collections/pull/508#issuecomment-2186443729
## [Codecov](https://app.codecov.io/gh/apache/commons-collections/pull/508?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 81.45%. Comparing base [(`229425c`)](https://app.codecov.io/gh/apache/commons-collections/commit/229425c302bae631570b0a6172beef8ec0bfc606?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6c45535`)](https://app.codecov.io/gh/apache/commons-collections/commit/6c455353df5395b02f92656f13bffcbb151557e8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 315 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #508 +/- ##
============================================
- Coverage 81.60% 81.45% -0.16%
- Complexity 4745 4834 +89
============================================
Files 295 300 +5
Lines 13751 14093 +342
Branches 2022 2071 +49
============================================
+ Hits 11222 11479 +257
- Misses 1929 1998 +69
- Partials 600 616 +16
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-collections/pull/508?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Collections-857] update bloom filter documentation [commons-collections]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #508:
URL: https://github.com/apache/commons-collections/pull/508#issuecomment-2186463505
Hi @Claudenw
Thank you for your PR.
Is there a reason we are documenting the feature in two places: In Javadoc and separate site pages? Why does some information go in one place vs. the other?
I always find that the "truth" is usually closest to the code and most likely to be maintained when near that code.
Also, note that starting with Java 18, we have the [_snippets_ Javadoc feature](https://blogs.oracle.com/javamagazine/post/java-javadoc-snippet). So I think that long term, all docs _should_ (IMO) go in Javadocs.
I don't know what happens if you plainly try to use snippets in Javadoc 8...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org