[GitHub] [druid] isandeep41 edited a comment on pull request #12252: add tier config in helm

[GitBox <gi...@apache.org>]

isandeep41 edited a comment on pull request #12252:
URL: https://github.com/apache/druid/pull/12252#issuecomment-1041056826


   @jaegwonseo 
   changes look great.
   
   here are few things need to be fixed
   1. [Helm chart test][1a] fails due to invalid Yaml document 
   ```sh
   ct lint --charts helm/druid --print-config --validate-maintainers=false
   
   ==> Linting helm/druid
   [ERROR] templates/historical/statefulset.yaml: unable to parse YAML: invalid Yaml document separator: apiVersion: apps/v1
   ```
   2. a [new line][2a] must be added at the end of `statefulset.yaml`
   
   [1a]: https://github.com/apache/druid/pull/12162 "enable github workflow to automate helm chart test #12162"
   [2a]: https://unix.stackexchange.com/questions/18743 "What's the point in adding a new line to the end of a file?"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org