You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/22 04:01:29 UTC
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19785
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
[tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
The TestNoMoreRetryWithWongServerUuid scenario of the DeleteTabletITest
was a bit flaky. The system catalog was sometimes sending in
DeleteTablet RPCs when the original tablet server was still starting
up, so even if DeleteTablet requests went through and were accounted
for, they were responded with an error status because the catalog
manager of the original tablet server wasn't ready to receive such
requests yet, and the catalog manager retried its requests after
receiving such responses.
This patch addresses the flakiness and fixes a typo in the name of the
scenario. The scenario's dist-test stats for a DEBUG build are below.
Before:
6 out of 1024 failed:
http://dist-test.cloudera.org/job?job_id=aserbin.1682129573.9602
After:
0 out of 1024 failed:
http://dist-test.cloudera.org/job?job_id=aserbin.1682133036.42291
Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
---
M src/kudu/integration-tests/delete_tablet-itest.cc
1 file changed, 33 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/19785/1
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19785 )
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 16:39:23 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19785 )
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
[tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
The TestNoMoreRetryWithWongServerUuid scenario of the DeleteTabletITest
was a bit flaky. The system catalog was sometimes sending in
DeleteTablet RPCs when the original tablet server was still starting
up, so even if DeleteTablet requests went through and were accounted
for, they were responded with an error status because the tablet
manager of the original tablet server wasn't ready to receive such
requests yet, and the catalog manager retried its requests after
receiving such responses.
This patch addresses the flakiness and fixes a typo in the name of the
scenario. The scenario's dist-test stats for a DEBUG build are below.
Before:
6 out of 1024 failed:
http://dist-test.cloudera.org/job?job_id=aserbin.1682129573.9602
After:
0 out of 1024 failed:
http://dist-test.cloudera.org/job?job_id=aserbin.1682133036.42291
Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Reviewed-on: http://gerrit.cloudera.org:8080/19785
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/integration-tests/delete_tablet-itest.cc
1 file changed, 33 insertions(+), 11 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19785 )
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:01:46 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19785 )
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 16:10:07 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19785 )
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
Patch Set 1: Verified+1
unrelated build termination after 50 minutes
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 22 Apr 2023 16:49:12 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19785 )
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19785/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19785/1//COMMIT_MSG@13
PS1, Line 13: catalog
: manager
nit: tablet manager
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sun, 23 Apr 2023 02:19:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19785
to look at the new patch set (#2).
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
[tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
The TestNoMoreRetryWithWongServerUuid scenario of the DeleteTabletITest
was a bit flaky. The system catalog was sometimes sending in
DeleteTablet RPCs when the original tablet server was still starting
up, so even if DeleteTablet requests went through and were accounted
for, they were responded with an error status because the tablet
manager of the original tablet server wasn't ready to receive such
requests yet, and the catalog manager retried its requests after
receiving such responses.
This patch addresses the flakiness and fixes a typo in the name of the
scenario. The scenario's dist-test stats for a DEBUG build are below.
Before:
6 out of 1024 failed:
http://dist-test.cloudera.org/job?job_id=aserbin.1682129573.9602
After:
0 out of 1024 failed:
http://dist-test.cloudera.org/job?job_id=aserbin.1682133036.42291
Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
---
M src/kudu/integration-tests/delete_tablet-itest.cc
1 file changed, 33 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/19785/2
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19785 )
Change subject: [tests] fix flakiness in TestNoMoreRetryWithWongServerUuid
......................................................................
Patch Set 2: Verified+1
(1 comment)
unrelated test failure in TabletCopyClientBasicTestModes/TabletCopyClientBasicTest.TestDownloadBlockMayFail/1 (DEBUG)
http://gerrit.cloudera.org:8080/#/c/19785/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19785/1//COMMIT_MSG@13
PS1, Line 13: tablet
: manager
> nit: tablet manager
Done
--
To view, visit http://gerrit.cloudera.org:8080/19785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3dee89b32d1e33d1f0f41e8b83835b02eae336
Gerrit-Change-Number: 19785
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:51:16 +0000
Gerrit-HasComments: Yes