You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/05/14 11:11:34 UTC
[GitHub] [hbase] nyl3532016 opened a new pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
nyl3532016 opened a new pull request #3266:
URL: https://github.com/apache/hbase/pull/3266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
nyl3532016 commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r633308440
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int numAlwaysStandByMasters,
hbaseCluster.addRegionServer(rsConf, i, user);
}
+ // manually add the compaction servers as other users
+ for (int i = 0; i < numCompactionServers; i++) {
Review comment:
You mean the compaction server and test code move to an independent module hbase-compaction-server, and this module depend on hbase-server module. I agree it's necessary.
Maybe we need introduce a wrap class `MiniHBaseClusterWithExtraServer` in module hbase-server, it combine `MiniHBaseCluster` and `AbstractServer`(can be compaction server or replication server).And `MiniHBaseClusterWithExtraServer` can be used in hbase-compaction-server and hbase-replication-server module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-841213751
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 47s | HBASE-25714 passed |
| +1 :green_heart: | compile | 8m 17s | HBASE-25714 passed |
| +1 :green_heart: | checkstyle | 2m 3s | HBASE-25714 passed |
| +1 :green_heart: | spotbugs | 11m 16s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 41s | the patch passed |
| +1 :green_heart: | compile | 8m 13s | the patch passed |
| +1 :green_heart: | javac | 8m 13s | the patch passed |
| -0 :warning: | checkstyle | 2m 2s | root: The patch generated 8 new + 251 unchanged - 1 fixed = 259 total (was 252) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 17m 53s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 11m 26s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | asflicense | 0m 42s | The patch generated 1 ASF License warnings. |
| | | 78m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml |
| uname | Linux 04528dca26f3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / 7f32d6cfc5 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| asflicense | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 141 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-841294935
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 19s | HBASE-25714 passed |
| +1 :green_heart: | compile | 2m 57s | HBASE-25714 passed |
| +1 :green_heart: | shadedjars | 7m 41s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 35s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 10s | the patch passed |
| +1 :green_heart: | compile | 2m 58s | the patch passed |
| +1 :green_heart: | javac | 2m 58s | the patch passed |
| -1 :x: | shadedjars | 0m 15s | patch has 10 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 34s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 188m 18s | root in the patch failed. |
| | | 222m 55s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 6f7bc70c0e48 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / 7f32d6cfc5 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/testReport/ |
| Max. process+thread count | 6802 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-851157205
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 36s | HBASE-25714 passed |
| +1 :green_heart: | compile | 8m 13s | HBASE-25714 passed |
| +1 :green_heart: | checkstyle | 2m 3s | HBASE-25714 passed |
| +1 :green_heart: | spotbugs | 11m 19s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 34s | the patch passed |
| +1 :green_heart: | compile | 8m 13s | the patch passed |
| +1 :green_heart: | javac | 8m 13s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 3s | root: The patch generated 0 new + 289 unchanged - 1 fixed = 289 total (was 290) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 17m 48s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 11m 53s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. |
| | | 78m 55s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml |
| uname | Linux 649ef53a2ac9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / fe47e48f0b |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 141 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r642075774
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/StartMiniClusterOption.java
##########
@@ -76,6 +76,11 @@
*/
private Class<? extends MiniHBaseCluster.MiniHBaseClusterRegionServer> rsClass;
+ /**
+ * Number of compaction servers to start up.
+ */
+ private final int numCompactionServers;
Review comment:
Why final?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
##########
@@ -122,7 +170,7 @@ public HMaster getMaster() {
* @param c Configuration to use.
* @param hmc Class to create.
* @param index Used distinguishing the object returned.
- * @throws IOException
+ * @throws IOException throw IOException
Review comment:
Just remove this line if nothing need to be documented?
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -101,16 +102,17 @@ public MiniHBaseCluster(Configuration conf, int numMasters, int numRegionServers
* @throws InterruptedException
*/
public MiniHBaseCluster(Configuration conf, int numMasters, int numAlwaysStandByMasters,
- int numRegionServers, List<Integer> rsPorts, Class<? extends HMaster> masterClass,
- Class<? extends MiniHBaseCluster.MiniHBaseClusterRegionServer> regionserverClass)
+ int numRegionServers, List<Integer> rsPorts, int numCompactionServers,
Review comment:
This class is marked as IA.Public, so you need to keep all the old constructors...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-850087440
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 59s | Docker failed to build yetus/hbase:92fe6090c2. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/4/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-849474501
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 55s | HBASE-25714 passed |
| +1 :green_heart: | compile | 8m 41s | HBASE-25714 passed |
| +1 :green_heart: | checkstyle | 2m 58s | HBASE-25714 passed |
| +1 :green_heart: | spotbugs | 15m 37s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 44s | the patch passed |
| +1 :green_heart: | compile | 10m 33s | the patch passed |
| +1 :green_heart: | javac | 10m 33s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 42s | root: The patch generated 0 new + 289 unchanged - 1 fixed = 289 total (was 290) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 25m 15s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 16m 4s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 46s | The patch does not generate ASF License warnings. |
| | | 107m 35s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml |
| uname | Linux 5698f75cbf59 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / f3bea21194 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 141 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-849839743
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 33s | HBASE-25714 passed |
| +1 :green_heart: | compile | 3m 1s | HBASE-25714 passed |
| +1 :green_heart: | shadedjars | 7m 49s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 59s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 17s | the patch passed |
| +1 :green_heart: | compile | 3m 8s | the patch passed |
| +1 :green_heart: | javac | 3m 8s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 15s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 25s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 199m 2s | root in the patch failed. |
| | | 243m 33s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b33fca9efc3a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / f3bea21194 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/testReport/ |
| Max. process+thread count | 6376 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-850221743
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 18s | HBASE-25714 passed |
| +1 :green_heart: | compile | 3m 4s | HBASE-25714 passed |
| +1 :green_heart: | shadedjars | 7m 54s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 58s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 16s | the patch passed |
| +1 :green_heart: | compile | 3m 1s | the patch passed |
| +1 :green_heart: | javac | 3m 1s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 28s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 25s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 199m 11s | root in the patch passed. |
| | | 243m 41s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 7f08d02c2cb2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / fe47e48f0b |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/testReport/ |
| Max. process+thread count | 6436 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-851236531
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 7s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 26s | HBASE-25714 passed |
| +1 :green_heart: | compile | 2m 58s | HBASE-25714 passed |
| +1 :green_heart: | shadedjars | 7m 49s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 36s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 15s | the patch passed |
| +1 :green_heart: | compile | 2m 58s | the patch passed |
| +1 :green_heart: | javac | 2m 58s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 52s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 31s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 188m 48s | root in the patch passed. |
| | | 231m 37s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 090a7e497840 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / fe47e48f0b |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/testReport/ |
| Max. process+thread count | 6526 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] nyl3532016 merged pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
nyl3532016 merged pull request #3266:
URL: https://github.com/apache/hbase/pull/3266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
nyl3532016 commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r635089665
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int numAlwaysStandByMasters,
hbaseCluster.addRegionServer(rsConf, i, user);
}
+ // manually add the compaction servers as other users
+ for (int i = 0; i < numCompactionServers; i++) {
Review comment:
@saintstack ping...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
nyl3532016 commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r640255301
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int numAlwaysStandByMasters,
hbaseCluster.addRegionServer(rsConf, i, user);
}
+ // manually add the compaction servers as other users
+ for (int i = 0; i < numCompactionServers; i++) {
Review comment:
Think twice, ITBLL need cover compaction server role, HBaseCluster has three types of cluster deployments: `MiniHBaseCluster`,`DistributedHBaseCluster`,`ProcessBasedLocalHBaseCluster`, all these classes should handle compaction server, maybe replication server also. So, It is better to integrate compaction server to `MiniHBaseCluster` for now? @saintstack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-850135296
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 46s | HBASE-25714 passed |
| +1 :green_heart: | compile | 8m 9s | HBASE-25714 passed |
| +1 :green_heart: | checkstyle | 2m 5s | HBASE-25714 passed |
| +1 :green_heart: | spotbugs | 11m 33s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 35s | the patch passed |
| +1 :green_heart: | compile | 8m 20s | the patch passed |
| +1 :green_heart: | javac | 8m 20s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 0s | root: The patch generated 0 new + 289 unchanged - 1 fixed = 289 total (was 290) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 20m 59s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 14m 48s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 42s | The patch does not generate ASF License warnings. |
| | | 87m 14s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml |
| uname | Linux 4dfce8fc4660 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / fe47e48f0b |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 141 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r633274298
##########
File path: hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/CompactionServerTests.java
##########
@@ -0,0 +1,4 @@
+package org.apache.hadoop.hbase.testclassification;
Review comment:
License?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/HCompactionServer.java
##########
@@ -174,13 +178,28 @@ public void run() {
abort("Fatal exception during initialization", e);
}
try {
+ if (!isStopped() && !isAborted()) {
+ while (keepLooping()) {
+ createCompactionServerStatusStub();
+ if (cssStub == null) {
+ this.sleeper.sleep(100);
+ } else {
+ break;
+ }
+ }
+ }
// We registered with the Master. Go into run mode.
long lastMsg = System.currentTimeMillis();
// The main run loop.
while (!isStopped()) {
long now = System.currentTimeMillis();
if ((now - lastMsg) >= msgInterval) {
- tryCompactionServerReport();
+ if (tryCompactionServerReport() && !online.get()) {
+ synchronized (online) {
+ online.set(true);
+ online.notifyAll();
+ }
+ }
lastMsg = System.currentTimeMillis();
}
if (!isStopped()) {
Review comment:
Can this server be moved out of the hbase-server package?
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int numAlwaysStandByMasters,
hbaseCluster.addRegionServer(rsConf, i, user);
}
+ // manually add the compaction servers as other users
+ for (int i = 0; i < numCompactionServers; i++) {
Review comment:
Does compaction server have to be this integrated?
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int numAlwaysStandByMasters,
hbaseCluster.addRegionServer(rsConf, i, user);
}
+ // manually add the compaction servers as other users
+ for (int i = 0; i < numCompactionServers; i++) {
Review comment:
Can it be moved outside hbase-server with its own test suite in its on hbase-compaction-server module? (Sorry, late to the game here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-849666124
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 53s | HBASE-25714 passed |
| +1 :green_heart: | compile | 2m 34s | HBASE-25714 passed |
| +1 :green_heart: | shadedjars | 7m 39s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 57s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 51s | the patch passed |
| +1 :green_heart: | compile | 2m 34s | the patch passed |
| +1 :green_heart: | javac | 2m 34s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 39s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 54s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 363m 0s | root in the patch failed. |
| | | 401m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b4bad534a74e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / f3bea21194 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/testReport/ |
| Max. process+thread count | 5744 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-849537479
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 34s | HBASE-25714 passed |
| +1 :green_heart: | compile | 3m 8s | HBASE-25714 passed |
| +1 :green_heart: | shadedjars | 8m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 58s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 19s | the patch passed |
| +1 :green_heart: | compile | 3m 2s | the patch passed |
| +1 :green_heart: | javac | 3m 2s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 27s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 26s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 166m 4s | root in the patch failed. |
| | | 210m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 93a0ee8c281a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / f3bea21194 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/testReport/ |
| Max. process+thread count | 3910 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
nyl3532016 commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r642184283
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/StartMiniClusterOption.java
##########
@@ -76,6 +76,11 @@
*/
private Class<? extends MiniHBaseCluster.MiniHBaseClusterRegionServer> rsClass;
+ /**
+ * Number of compaction servers to start up.
+ */
+ private final int numCompactionServers;
Review comment:
Variables in `StartMiniClusterOption` are all declared final, the `StartMiniClusterOption` is useless after minicluster startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-849730040
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 40s | HBASE-25714 passed |
| +1 :green_heart: | compile | 8m 10s | HBASE-25714 passed |
| +1 :green_heart: | checkstyle | 2m 4s | HBASE-25714 passed |
| +1 :green_heart: | spotbugs | 11m 28s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 35s | the patch passed |
| +1 :green_heart: | compile | 8m 15s | the patch passed |
| +1 :green_heart: | javac | 8m 15s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 3s | root: The patch generated 0 new + 289 unchanged - 1 fixed = 289 total (was 290) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 17m 57s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 11m 40s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. |
| | | 79m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml |
| uname | Linux 88c69c81ee0f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / f3bea21194 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 141 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/3/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-851327142
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 33s | HBASE-25714 passed |
| +1 :green_heart: | compile | 2m 34s | HBASE-25714 passed |
| +1 :green_heart: | shadedjars | 7m 40s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 54s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 31s | the patch passed |
| +1 :green_heart: | compile | 2m 31s | the patch passed |
| +1 :green_heart: | javac | 2m 31s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 44s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 50s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 311m 15s | root in the patch failed. |
| | | 348m 37s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux a88d9eb4ac93 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / fe47e48f0b |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/testReport/ |
| Max. process+thread count | 3841 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/6/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
nyl3532016 commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r633308440
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int numAlwaysStandByMasters,
hbaseCluster.addRegionServer(rsConf, i, user);
}
+ // manually add the compaction servers as other users
+ for (int i = 0; i < numCompactionServers; i++) {
Review comment:
You mean the compaction server and test code move to an independent module hbase-compaction-server, and this module depend on hbase-server module. I agree it's necessary.
Maybe we need introduce a wrap class `MiniHBaseClusterWithExtraServer` in module hbase-server, it combine `MiniHBaseCluster` and `AbstractServer`(can be compaction server or replication server).And `MiniHBaseClusterWithExtraServer` can be used in hbase-compaction-server and hbase-replication-server module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#issuecomment-850280500
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ HBASE-25714 Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 40s | HBASE-25714 passed |
| +1 :green_heart: | compile | 2m 34s | HBASE-25714 passed |
| +1 :green_heart: | shadedjars | 7m 42s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 59s | HBASE-25714 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 52s | the patch passed |
| +1 :green_heart: | compile | 2m 32s | the patch passed |
| +1 :green_heart: | javac | 2m 32s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 47s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 53s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 300m 43s | root in the patch failed. |
| | | 339m 3s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3266 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b373a5dd62ba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-25714 / fe47e48f0b |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/testReport/ |
| Max. process+thread count | 3291 (vs. ulimit of 30000) |
| modules | C: hbase-annotations hbase-server . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3266/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r633274298
##########
File path: hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/CompactionServerTests.java
##########
@@ -0,0 +1,4 @@
+package org.apache.hadoop.hbase.testclassification;
Review comment:
License?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/HCompactionServer.java
##########
@@ -174,13 +178,28 @@ public void run() {
abort("Fatal exception during initialization", e);
}
try {
+ if (!isStopped() && !isAborted()) {
+ while (keepLooping()) {
+ createCompactionServerStatusStub();
+ if (cssStub == null) {
+ this.sleeper.sleep(100);
+ } else {
+ break;
+ }
+ }
+ }
// We registered with the Master. Go into run mode.
long lastMsg = System.currentTimeMillis();
// The main run loop.
while (!isStopped()) {
long now = System.currentTimeMillis();
if ((now - lastMsg) >= msgInterval) {
- tryCompactionServerReport();
+ if (tryCompactionServerReport() && !online.get()) {
+ synchronized (online) {
+ online.set(true);
+ online.notifyAll();
+ }
+ }
lastMsg = System.currentTimeMillis();
}
if (!isStopped()) {
Review comment:
Can this server be moved out of the hbase-server package?
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int numAlwaysStandByMasters,
hbaseCluster.addRegionServer(rsConf, i, user);
}
+ // manually add the compaction servers as other users
+ for (int i = 0; i < numCompactionServers; i++) {
Review comment:
Does compaction server have to be this integrated?
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int numAlwaysStandByMasters,
hbaseCluster.addRegionServer(rsConf, i, user);
}
+ // manually add the compaction servers as other users
+ for (int i = 0; i < numCompactionServers; i++) {
Review comment:
Can it be moved outside hbase-server with its own test suite in its on hbase-compaction-server module? (Sorry, late to the game here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org