[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #306: HDDS-2667. Promethues reports invalid metric type

[GitBox <gi...@apache.org>]

adoroszlai opened a new pull request #306: HDDS-2667. Promethues reports invalid metric type
URL: https://github.com/apache/hadoop-ozone/pull/306
 
 
   ## What changes were proposed in this pull request?
   
   Normalize RocksDB metrics record name, which comes from DB file names (eg. `om.db -> Rocksdb_om.db`), because periods are not allowed in Prometheus metrics names.
   
   https://issues.apache.org/jira/browse/HDDS-2667
   
   ## How was this patch tested?
   
   Changed existing unit test.
   
   Tested using `ozoneperf` environment after enabling RocksDB metrics in `docker-config`:
   
   ```
   OZONE-SITE.XML_ozone.metastore.rocksdb.statistics=ALL
   ```
   
   and creating test data with Freon:
   
   ```
   docker-compose exec scm ozone freon ockg -t 1 -n 1
   ```
   
   Verified that Prometheus shows all datanodes, OM, SCM as up.  Verified that `/prom` endpoint and Prometheus show RocksDB metrics with normalized names, eg:
   
   ```
   # TYPE rocksdb_om_db_wal_file_bytes counter
   rocksdb_om_db_wal_file_bytes{hostname="198e740b5533"} 1823
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org